Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2915263003: Implement getClassAsInstanceOf() and getTypeAsInstanceOf() for IncrementalClassHierarchy. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement getClassAsInstanceOf() and getTypeAsInstanceOf() for IncrementalClassHierarchy. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c2b5ae00ceeb0631fe59c5349cd0331d7c4c2278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -42 lines) Patch
M pkg/kernel/lib/src/incremental_class_hierarchy.dart View 6 chunks +100 lines, -7 lines 0 comments Download
M pkg/kernel/test/class_hierarchy_test.dart View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-02 16:56:32 UTC) #1
Paul Berry
lgtm
3 years, 6 months ago (2017-06-02 18:35:38 UTC) #2
scheglov
3 years, 6 months ago (2017-06-02 18:54:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2b5ae00ceeb0631fe59c5349cd0331d7c4c2278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698