Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_analysis.dart

Issue 2915173003: Avoid adding constants for emission during resolution. (Closed)
Patch Set: Conditionally Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/mirrors_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/mirrors_analysis.dart
diff --git a/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart b/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart
index b3617d8c57d5e4069ec09f5a08ae590c4b0bc210..6bc41cc82f3e19144a0dade020f311773be6bcc1 100644
--- a/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart
+++ b/pkg/compiler/lib/src/js_backend/mirrors_analysis.dart
@@ -126,8 +126,10 @@ class MirrorsResolutionAnalysisImpl implements MirrorsResolutionAnalysis {
if (_mirrorsData.mustRetainMetadata) {
_reporter.log('Retaining metadata.');
- (_compiler.libraryLoader.libraries as Iterable<LibraryElement>)
- .forEach(_mirrorsData.retainMetadataOfLibrary);
+ for (LibraryEntity library in _compiler.libraryLoader.libraries) {
+ _mirrorsData.retainMetadataOfLibrary(library,
+ addForEmission: !enqueuer.isResolutionQueue);
+ }
if (!enqueuer.queueIsClosed) {
/// Register the constant value of [metadata] as live in resolution.
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/mirrors_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698