Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2915173003: Avoid adding constants for emission during resolution. (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid adding constants for emission during resolution. Committed: https://github.com/dart-lang/sdk/commit/43dc39c5856bf1cb699d40776777ea05e19fd188

Patch Set 1 #

Patch Set 2 : Conditionally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
3 years, 6 months ago (2017-06-02 12:26:42 UTC) #2
Johnni Winther
Committed patchset #2 (id:20001) manually as 43dc39c5856bf1cb699d40776777ea05e19fd188 (presubmit successful).
3 years, 6 months ago (2017-06-02 12:27:02 UTC) #4
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-02 16:43:48 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698