Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 291513003: Remove PlatformFile from fileapi::FileSystemOperation (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
Reviewers:
kinuko, bbudge
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik
Visibility:
Public.

Description

Remove PlatformFile from fileapi::FileSystemOperation BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272661

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : Fix recent bot failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -89 lines) Patch
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_io_host.h View 3 chunks +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_io_host.cc View 1 4 chunks +13 lines, -21 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation.h View 10 chunks +24 lines, -26 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
rvargas (doing something else)
PTAL bbudge -> pepper kinuko -> everything else.
6 years, 7 months ago (2014-05-22 00:36:59 UTC) #1
kinuko
On 2014/05/22 00:36:59, rvargas wrote: > PTAL > > bbudge -> pepper > kinuko -> ...
6 years, 7 months ago (2014-05-22 04:13:32 UTC) #2
bbudge
Pepper lgtm https://codereview.chromium.org/291513003/diff/90001/content/browser/renderer_host/pepper/pepper_file_io_host.cc File content/browser/renderer_host/pepper/pepper_file_io_host.cc (right): https://codereview.chromium.org/291513003/diff/90001/content/browser/renderer_host/pepper/pepper_file_io_host.cc#newcode253 content/browser/renderer_host/pepper/pepper_file_io_host.cc:253: Passed(&file))); nit: could you fully qualify this ...
6 years, 7 months ago (2014-05-22 17:12:20 UTC) #3
rvargas (doing something else)
Thanks https://codereview.chromium.org/291513003/diff/90001/content/browser/renderer_host/pepper/pepper_file_io_host.cc File content/browser/renderer_host/pepper/pepper_file_io_host.cc (right): https://codereview.chromium.org/291513003/diff/90001/content/browser/renderer_host/pepper/pepper_file_io_host.cc#newcode253 content/browser/renderer_host/pepper/pepper_file_io_host.cc:253: Passed(&file))); On 2014/05/22 17:12:20, bbudge wrote: > nit: ...
6 years, 7 months ago (2014-05-22 20:52:53 UTC) #4
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-22 20:52:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/291513003/110001
6 years, 7 months ago (2014-05-22 20:53:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 01:54:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 02:08:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/145258) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/187544)
6 years, 7 months ago (2014-05-23 02:08:52 UTC) #9
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-23 19:33:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/291513003/130001
6 years, 7 months ago (2014-05-23 19:34:51 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 01:05:24 UTC) #12
Message was sent while issue was closed.
Change committed as 272661

Powered by Google App Engine
This is Rietveld 408576698