Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 291503007: bookmarks: Componentize bookmark_model_unittest.cc. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
sdefresne, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

bookmarks: Componentize bookmark_model_unittest.cc. Few changes involved: 1) Using TestBookmarkClient to create BookmarkModel. 2) Removes unnecessary TestBrowserThreadBundle 3) With the above changes TestingProfile and BookmarkModelFactory goes away. BUG=367834 TEST=components_unittests --gtest_filter=BookmarkModel* R=blundell@chromium.org, sdefresne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271064

Patch Set 1 #

Patch Set 2 : rm it from chrome_tests_unit.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1200 lines) Patch
D chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 chunk +0 lines, -1160 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
A + components/bookmarks/core/browser/bookmark_model_unittest.cc View 4 chunks +11 lines, -39 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
minimal changes. ptal.
6 years, 7 months ago (2014-05-16 02:56:13 UTC) #1
blundell
Trybots seem unhappy
6 years, 7 months ago (2014-05-16 07:17:49 UTC) #2
sdefresne
Change looks fine. I think you forgot to remove browser/bookmarks/bookmark_model_unittests.cc from chrome/chrome_tests_unit.gypi and this is ...
6 years, 7 months ago (2014-05-16 09:43:24 UTC) #3
tfarina
On 2014/05/16 09:43:24, sdefresne wrote: > Change looks fine. > > I think you forgot ...
6 years, 7 months ago (2014-05-16 15:37:46 UTC) #4
tfarina
On 2014/05/16 15:37:46, tfarina wrote: > On 2014/05/16 09:43:24, sdefresne wrote: > > Change looks ...
6 years, 7 months ago (2014-05-16 15:39:00 UTC) #5
blundell
LGTM
6 years, 7 months ago (2014-05-16 15:42:37 UTC) #6
sdefresne
lgtm
6 years, 7 months ago (2014-05-16 16:05:42 UTC) #7
tfarina
6 years, 7 months ago (2014-05-16 18:28:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r271064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698