Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 291503006: views: Remove standard frame when running views_examples_with_content_exe on Linux. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

views: Remove standard frame when running views_examples_with_content_exe on Linux. If we don't do this, then the standard frame appears with the blue one provided by views, presenting two title bars with the same information, which looks ugly. BUG=374046 TEST=build views_examples_with_content_exe on Linux, run it. Observe. The window displayed must have a unique frame, the blue one. See bug for previous-after screenshots. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/examples/examples_window.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 7 months ago (2014-05-16 02:54:31 UTC) #1
sky
Is this code also used from ash_shell?
6 years, 7 months ago (2014-05-16 16:55:27 UTC) #2
tfarina
On 2014/05/16 16:55:27, sky wrote: > Is this code also used from ash_shell? Yes. It ...
6 years, 7 months ago (2014-05-16 21:13:57 UTC) #3
sky
LGTM
6 years, 7 months ago (2014-05-16 22:51:33 UTC) #4
tfarina
6 years, 7 months ago (2014-05-20 17:24:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r271681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698