Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc

Issue 2914993002: [Merge M60] arc: Ignore icon invalidation on Play Store update. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
index 12ef2a996cc901aaff7841cd07c12873e50ee4b4..82dfdfe9f5cb8e1aa7904bc96c8419bf616c8fa3 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
@@ -362,6 +362,8 @@ void ArcAppListPrefs::ClearIconRequestRecord() {
void ArcAppListPrefs::RequestIcon(const std::string& app_id,
ui::ScaleFactor scale_factor) {
+ DCHECK_NE(app_id, arc::kPlayStoreAppId);
+
// ArcSessionManager can be terminated during test tear down, before callback
// into this function.
// TODO(victorhsieh): figure out the best way/place to handle this situation.
@@ -1101,10 +1103,13 @@ void ArcAppListPrefs::OnPackageAppListRefreshed(
const std::string app_id = GetAppId(app->package_name, app->activity);
apps_to_remove.erase(app_id);
- // Mark app icons as invalidated.
- ScopedArcPrefUpdate update(prefs_, app_id, prefs::kArcApps);
- base::DictionaryValue* app_dict = update.Get();
- app_dict->SetInteger(kInvalidatedIcons, invalidated_icon_mask);
+ // Mark app icons as invalidated. Ignore Play Store app since we provide its
+ // icon in Chrome resources.
+ if (app_id != arc::kPlayStoreAppId) {
+ ScopedArcPrefUpdate update(prefs_, app_id, prefs::kArcApps);
+ base::DictionaryValue* app_dict = update.Get();
+ app_dict->SetInteger(kInvalidatedIcons, invalidated_icon_mask);
+ }
AddApp(*app);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698