Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 291493005: Fix a typo in glBufferData and glBufferSubData 's arguments (Closed)

Created:
6 years, 7 months ago by penghu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, bsalomon_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

The function glBufferData 's second argument type is GLsizeiptr, not GLsizei. glBufferSubData 's second argument type is GLintptr, not GLint. And the third argument type is GLsizeiptr, not GLsizei. A mistake in glBufferData and glBufferSubData 's arguments. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/generate_bindings.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
penghu
The CQ bit was checked by penghu@tencent.com
6 years, 7 months ago (2014-05-16 05:19:05 UTC) #1
penghu
The CQ bit was unchecked by penghu@tencent.com
6 years, 7 months ago (2014-05-16 05:19:06 UTC) #2
penghu
6 years, 7 months ago (2014-05-21 09:25:42 UTC) #3
Ken Russell (switch to Gerrit)
Thanks for noticing this but what prompted the change? This will only have an effect ...
6 years, 7 months ago (2014-05-21 19:06:00 UTC) #4
Ken Russell (switch to Gerrit)
Also, have you signed the individual contributor licensing agreement per http://dev.chromium.org/developers/contributing-code#TOC-Get-your-code-ready ?
6 years, 7 months ago (2014-05-21 19:07:13 UTC) #5
Wei Xiaohai
On 2014/05/21 19:07:13, Ken Russell wrote: > Also, have you signed the individual contributor licensing ...
6 years, 7 months ago (2014-05-22 02:16:05 UTC) #6
Ken Russell (switch to Gerrit)
On 2014/05/22 02:16:05, jamesxwei wrote: > On 2014/05/21 19:07:13, Ken Russell wrote: > > Also, ...
6 years, 7 months ago (2014-05-22 02:57:15 UTC) #7
penghu
On 2014/05/22 02:57:15, Ken Russell wrote: > On 2014/05/22 02:16:05, jamesxwei wrote: > > On ...
6 years, 7 months ago (2014-05-22 03:30:05 UTC) #8
Ken Russell (switch to Gerrit)
On 2014/05/22 03:30:05, penghu wrote: > On 2014/05/22 02:57:15, Ken Russell wrote: > > On ...
6 years, 7 months ago (2014-05-24 02:31:07 UTC) #9
penghu
The CQ bit was checked by penghu@tencent.com
6 years, 7 months ago (2014-05-26 05:42:45 UTC) #10
penghu
The CQ bit was unchecked by penghu@tencent.com
6 years, 7 months ago (2014-05-26 05:42:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghu@tencent.com/291493005/1
6 years, 7 months ago (2014-05-26 05:42:53 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 05:42:55 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-26 05:42:55 UTC) #14
Ken Russell (switch to Gerrit)
LGTM since the GPU bots' runs looked good.
6 years, 7 months ago (2014-05-27 21:48:35 UTC) #15
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 7 months ago (2014-05-27 21:48:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghu@tencent.com/291493005/1
6 years, 7 months ago (2014-05-27 21:49:54 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 01:44:37 UTC) #18
Message was sent while issue was closed.
Change committed as 273106

Powered by Google App Engine
This is Rietveld 408576698