Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2914893003: Revert "Replace the configuration map with a typed object." (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Replace the configuration map with a typed object." This reverts commit 06f75fe5cd99aa5f85d2afaacd6dddc95e1570d9. Committed: https://github.com/dart-lang/sdk/commit/8bada4873ad171fe031d8c9a69ddca95131b1d94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1466 lines, -1930 lines) Patch
M tests/lib/lib.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/status_expression_test.dart View 4 chunks +10 lines, -18 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 16 chunks +70 lines, -62 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tools/testing/dart/co19_test_config.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 13 chunks +119 lines, -99 lines 0 comments Download
D tools/testing/dart/configuration.dart View 1 chunk +0 lines, -741 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 2 chunks +9 lines, -8 lines 0 comments Download
D tools/testing/dart/environment.dart View 1 chunk +0 lines, -105 lines 0 comments Download
M tools/testing/dart/expectation_set.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/testing/dart/http_server.dart View 4 chunks +9 lines, -8 lines 0 comments Download
M tools/testing/dart/launch_browser.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M tools/testing/dart/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/options.dart View 16 chunks +348 lines, -214 lines 0 comments Download
M tools/testing/dart/package_testing_support.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 4 chunks +67 lines, -69 lines 0 comments Download
M tools/testing/dart/status_expression.dart View 6 chunks +6 lines, -30 lines 0 comments Download
M tools/testing/dart/status_file.dart View 6 chunks +16 lines, -52 lines 0 comments Download
M tools/testing/dart/status_reporter.dart View 5 chunks +90 lines, -79 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 11 chunks +119 lines, -85 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 7 chunks +49 lines, -40 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 21 chunks +71 lines, -57 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 53 chunks +400 lines, -235 lines 0 comments Download
M tools/testing/dart/utils.dart View 2 chunks +56 lines, -0 lines 0 comments Download
M tools/testing/dart/vm_test_config.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
Looks like this broke the product builds, reverting. TBR.
3 years, 6 months ago (2017-05-31 22:08:09 UTC) #2
Bob Nystrom
Committed patchset #1 (id:1) manually as 8bada4873ad171fe031d8c9a69ddca95131b1d94 (presubmit successful).
3 years, 6 months ago (2017-05-31 22:08:25 UTC) #4
Paul Berry
3 years, 6 months ago (2017-05-31 22:08:42 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698