Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2914893002: Move some of IOThread's command line logic to network_session_configurator. (Closed)
Patch Set: Fix merge Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
deleted file mode 100644
index 4fe02d241f09870fe595f24c9f42024b510cfab9..0000000000000000000000000000000000000000
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ /dev/null
@@ -1,357 +0,0 @@
-// Copyright (c) 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "components/network_session_configurator/network_session_configurator.h"
-
-#include <map>
-#include <memory>
-
-#include "base/memory/ptr_util.h"
-#include "base/metrics/field_trial.h"
-#include "base/test/mock_entropy_provider.h"
-#include "components/variations/variations_associated_data.h"
-#include "net/http/http_stream_factory.h"
-#include "net/quic/core/quic_packets.h"
-#include "net/spdy/core/spdy_protocol.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace test {
-
-class NetworkSessionConfiguratorTest : public testing::Test {
- public:
- NetworkSessionConfiguratorTest()
- : quic_user_agent_id_("Chrome/52.0.2709.0 Linux x86_64") {
- field_trial_list_.reset(
- new base::FieldTrialList(
- base::MakeUnique<base::MockEntropyProvider>()));
- variations::testing::ClearAllVariationParams();
- }
-
- void ParseFieldTrials() {
- network_session_configurator::ParseFieldTrials(
- /*is_quic_force_disabled=*/false,
- /*is_quic_force_enabled=*/false, quic_user_agent_id_, &params_);
- }
-
- std::string quic_user_agent_id_;
- std::unique_ptr<base::FieldTrialList> field_trial_list_;
- net::HttpNetworkSession::Params params_;
-};
-
-TEST_F(NetworkSessionConfiguratorTest, Defaults) {
- ParseFieldTrials();
-
- EXPECT_FALSE(params_.ignore_certificate_errors);
- EXPECT_EQ("Chrome/52.0.2709.0 Linux x86_64", params_.quic_user_agent_id);
- EXPECT_EQ(0u, params_.testing_fixed_http_port);
- EXPECT_EQ(0u, params_.testing_fixed_https_port);
- EXPECT_TRUE(params_.enable_http2);
- EXPECT_TRUE(params_.http2_settings.empty());
- EXPECT_FALSE(params_.enable_tcp_fast_open_for_ssl);
- EXPECT_FALSE(params_.enable_quic);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, Http2FieldTrialHttp2Disable) {
- base::FieldTrialList::CreateFieldTrial("HTTP2", "Disable");
-
- ParseFieldTrials();
-
- EXPECT_FALSE(params_.enable_http2);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.enable_quic);
- EXPECT_FALSE(params_.mark_quic_broken_when_network_blackholes);
- EXPECT_FALSE(params_.retry_without_alt_svc_on_quic_errors);
- EXPECT_EQ(1350u, params_.quic_max_packet_length);
- EXPECT_EQ(net::QuicTagVector(), params_.quic_connection_options);
- EXPECT_FALSE(params_.enable_server_push_cancellation);
- EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
- EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
- params_.quic_idle_connection_timeout_seconds);
- EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
- EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds,
- params_.quic_packet_reader_yield_after_duration_milliseconds);
- EXPECT_FALSE(params_.quic_race_cert_verification);
- EXPECT_FALSE(params_.quic_do_not_fragment);
- EXPECT_FALSE(params_.quic_estimate_initial_rtt);
- EXPECT_FALSE(params_.quic_migrate_sessions_on_network_change);
- EXPECT_FALSE(params_.quic_migrate_sessions_early);
- EXPECT_FALSE(params_.quic_allow_server_migration);
- EXPECT_FALSE(params_.quic_force_hol_blocking);
-
- net::HttpNetworkSession::Params default_params;
- EXPECT_EQ(default_params.quic_supported_versions,
- params_.quic_supported_versions);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["enable_quic"] = "true";
- variations::AssociateVariationParams("QUIC", "UseQuic", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "UseQuic");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.enable_quic);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, EnableQuicForDataReductionProxy) {
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
- base::FieldTrialList::CreateFieldTrial("DataReductionProxyUseQuic",
- "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.enable_quic);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- MarkQuicBrokenWhenNetworkBlackholesFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["mark_quic_broken_when_network_blackholes"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.mark_quic_broken_when_network_blackholes);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, RetryWithoutAltSvcOnQuicErrors) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["retry_without_alt_svc_on_quic_errors"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.retry_without_alt_svc_on_quic_errors);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicCloseSessionsOnIpChangeFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["close_sessions_on_ip_change"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_close_sessions_on_ip_change);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicIdleConnectionTimeoutSecondsFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["idle_connection_timeout_seconds"] = "300";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_EQ(300, params_.quic_idle_connection_timeout_seconds);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- NegativeQuicReducedPingTimeoutSecondsFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["reduced_ping_timeout_seconds"] = "-5";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
- ParseFieldTrials();
- EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- LargeQuicReducedPingTimeoutSecondsFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["reduced_ping_timeout_seconds"] = "50";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
- ParseFieldTrials();
- EXPECT_EQ(net::kPingTimeoutSecs, params_.quic_reduced_ping_timeout_seconds);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicReducedPingTimeoutSecondsFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["reduced_ping_timeout_seconds"] = "10";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
- ParseFieldTrials();
- EXPECT_EQ(10, params_.quic_reduced_ping_timeout_seconds);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicPacketReaderYieldAfterDurationMillisecondsFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["packet_reader_yield_after_duration_milliseconds"] = "10";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_EQ(10, params_.quic_packet_reader_yield_after_duration_milliseconds);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, QuicRaceCertVerification) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["race_cert_verification"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_race_cert_verification);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, EnableServerPushCancellation) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["enable_server_push_cancellation"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.enable_server_push_cancellation);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, QuicDoNotFragment) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["do_not_fragment"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_do_not_fragment);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, QuicEstimateInitialRtt) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["estimate_initial_rtt"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_estimate_initial_rtt);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicMigrateSessionsOnNetworkChangeFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["migrate_sessions_on_network_change"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_migrate_sessions_on_network_change);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicMigrateSessionsEarlyFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["migrate_sessions_early"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_migrate_sessions_early);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicAllowServerMigrationFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["allow_server_migration"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_allow_server_migration);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, PacketLengthFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["max_packet_length"] = "1450";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_EQ(1450u, params_.quic_max_packet_length);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, QuicVersionFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["quic_version"] =
- net::QuicVersionToString(net::AllSupportedVersions().back());
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- net::QuicVersionVector supported_versions;
- supported_versions.push_back(net::AllSupportedVersions().back());
- EXPECT_EQ(supported_versions, params_.quic_supported_versions);
-}
-
-TEST_F(NetworkSessionConfiguratorTest,
- QuicConnectionOptionsFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["connection_options"] = "TIME,TBBR,REJ";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- net::QuicTagVector options;
- options.push_back(net::kTIME);
- options.push_back(net::kTBBR);
- options.push_back(net::kREJ);
- EXPECT_EQ(options, params_.quic_connection_options);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, Http2SettingsFromFieldTrialParams) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["http2_settings"] = "7:1234,25:5678";
- variations::AssociateVariationParams("HTTP2", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("HTTP2", "Enabled");
-
- ParseFieldTrials();
-
- net::SettingsMap expected_settings;
- expected_settings[static_cast<net::SpdySettingsIds>(7)] = 1234;
- expected_settings[static_cast<net::SpdySettingsIds>(25)] = 5678;
- EXPECT_EQ(expected_settings, params_.http2_settings);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, TCPFastOpenHttpsEnabled) {
- base::FieldTrialList::CreateFieldTrial("TCPFastOpen", "HttpsEnabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.enable_tcp_fast_open_for_ssl);
-}
-
-TEST_F(NetworkSessionConfiguratorTest, QuicForceHolBlocking) {
- std::map<std::string, std::string> field_trial_params;
- field_trial_params["force_hol_blocking"] = "true";
- variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
- base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
-
- ParseFieldTrials();
-
- EXPECT_TRUE(params_.quic_force_hol_blocking);
-}
-
-} // namespace test
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698