 Chromium Code Reviews
 Chromium Code Reviews Issue 2914893002:
  Move some of IOThread's command line logic to network_session_configurator.  (Closed)
    
  
    Issue 2914893002:
  Move some of IOThread's command line logic to network_session_configurator.  (Closed) 
  | Index: android_webview/browser/net/aw_url_request_context_getter.cc | 
| diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc | 
| index 0f4c68aa43e1e5024bc9acdcd3ce5933f79df9c3..d6ea84f62b7dab68369ee5f08501be76c0c2140e 100644 | 
| --- a/android_webview/browser/net/aw_url_request_context_getter.cc | 
| +++ b/android_webview/browser/net/aw_url_request_context_getter.cc | 
| @@ -24,6 +24,7 @@ | 
| #include "base/strings/string_number_conversions.h" | 
| #include "base/task_scheduler/post_task.h" | 
| #include "base/threading/sequenced_worker_pool.h" | 
| +#include "components/network_session_configurator/common/network_switches.h" | 
| #include "components/prefs/pref_service.h" | 
| #include "content/public/browser/browser_thread.h" | 
| #include "content/public/browser/content_browser_client.h" | 
| @@ -85,6 +86,7 @@ void ApplyCmdlineOverridesToHostResolver( | 
| void ApplyCmdlineOverridesToNetworkSessionParams( | 
| net::HttpNetworkSession::Params* params) { | 
| + // TODO(mmenke): Should this use network_session_configurator? | 
| 
Tobias Sargeant
2017/06/09 17:55:36
I think the answer to this is at the moment no, be
 
mmenke
2017/06/09 18:02:35
But it also sets up command line flags, including
 | 
| int value; | 
| const base::CommandLine& command_line = | 
| *base::CommandLine::ForCurrentProcess(); |