Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: components/network_session_configurator/browser/network_session_configurator_unittest.cc

Issue 2914893002: Move some of IOThread's command line logic to network_session_configurator. (Closed)
Patch Set: Fixes... Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/browser/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/browser/network_session_configurator_unittest.cc
similarity index 96%
rename from components/network_session_configurator/network_session_configurator_unittest.cc
rename to components/network_session_configurator/browser/network_session_configurator_unittest.cc
index 4fe02d241f09870fe595f24c9f42024b510cfab9..401c309a23de70d9eaa869e434edb1d40714be75 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/browser/network_session_configurator_unittest.cc
@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/network_session_configurator/network_session_configurator.h"
+#include "components/network_session_configurator/browser/network_session_configurator.h"
#include <map>
#include <memory>
+#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/field_trial.h"
#include "base/test/mock_entropy_provider.h"
@@ -22,16 +23,16 @@ class NetworkSessionConfiguratorTest : public testing::Test {
public:
NetworkSessionConfiguratorTest()
: quic_user_agent_id_("Chrome/52.0.2709.0 Linux x86_64") {
- field_trial_list_.reset(
- new base::FieldTrialList(
- base::MakeUnique<base::MockEntropyProvider>()));
+ field_trial_list_.reset(new base::FieldTrialList(
+ base::MakeUnique<base::MockEntropyProvider>()));
variations::testing::ClearAllVariationParams();
}
void ParseFieldTrials() {
- network_session_configurator::ParseFieldTrials(
- /*is_quic_force_disabled=*/false,
- /*is_quic_force_enabled=*/false, quic_user_agent_id_, &params_);
+ base::CommandLine command_line(base::CommandLine::NO_PROGRAM);
+ network_session_configurator::ParseCommandLineAndFieldTrials(
+ command_line, /*is_quic_force_disabled=*/false, quic_user_agent_id_,
+ &params_);
}
std::string quic_user_agent_id_;

Powered by Google App Engine
This is Rietveld 408576698