On 2017/06/02 20:49:04, Ryan Hamilton wrote:
> This is probably obvious, but what's the difference between browser/ and
> common/? Should we add a comment about that somewhere?
It's pretty common for components to have directories with these names
(https://cs.chromium.org/search/?q=file:components/.*/browser/$+package:%5Echr...
- looks like over 100 components do this). In general common/ can be included
by anything, and browser/ can only be included by things that live only in the
browser process (content/browser, chrome/browser, or things only they include or
that include them). Since HttpNetworkSession can't be used in most processes,
seems like, for example, a file in content/common shouldn't be depending on it.
This is a common enough pattern that I'm not sure if it needs to be documented
(I'm also not sure about where this should be documented, if we chose to do so).
Ryan Hamilton
2017/06/07 18:15:44
Ok, fair enough!
On 2017/06/05 18:43:27, mmenke wrote:
> On 2017/06/02 20:49:04, Ryan Hamilton wrote:
> > This is probably obvious, but what's the difference between browser/ and
> > common/? Should we add a comment about that somewhere?
>
> It's pretty common for components to have directories with these names
>
(https://cs.chromium.org/search/?q=file:components/.*/browser/$+package:%5Echr...
> - looks like over 100 components do this). In general common/ can be included
> by anything, and browser/ can only be included by things that live only in the
> browser process (content/browser, chrome/browser, or things only they include
or
> that include them). Since HttpNetworkSession can't be used in most processes,
> seems like, for example, a file in content/common shouldn't be depending on
it.
>
> This is a common enough pattern that I'm not sure if it needs to be documented
> (I'm also not sure about where this should be documented, if we chose to do
so).
Issue 2914893002: Move some of IOThread's command line logic to network_session_configurator.
(Closed)
Created 3 years, 6 months ago by mmenke
Modified 3 years, 6 months ago
Reviewers: jochen (gone - plz use gerrit), jam, lcwu1, Ryan Hamilton, rkc, rohitrao (ping after 24h), Tobias Sargeant
Base URL:
Comments: 12