Refactor fetch_benchmark_deps.py script to allow fetching all benchmark deps

tools/perf/fetch_benchmark_deps.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module fetches and prints the dependencies given a benchmark."""
 
+import argparse
 import os
 import sys
 
+from core import benchmark_finders
 from core import path_util
 
 path_util.AddPyUtilsToPath()
 from py_utils import cloud_storage
 
 path_util.AddTelemetryToPath()
 from telemetry import benchmark_runner
 
 from chrome_telemetry_build import chromium_config
 
@@ skipping 29 matching lines @@
         path_name, extension = os.path.splitext(
             os.path.join(dirpath, filename))
         if extension == '.sha1':
           deps.add(path_name)
 
   # Return relative paths.
   prefix_len = len(os.path.realpath(path_util.GetChromiumSrcDir())) + 1
   return [dep[prefix_len:] for dep in deps if dep]
 
 
-def _show_usage():
-  print ('Usage: %s benchmark_name\n'
-         'Fetch the dependencies of benchmark_name.' % sys.argv[0])
-
-
-def main(output=sys.stdout):
-  config = chromium_config.ChromiumConfig(
-      top_level_dir=path_util.GetPerfDir(),
-      benchmark_dirs=[os.path.join(path_util.GetPerfDir(), 'benchmarks')])
-
-  name = sys.argv[1]
-  benchmark = benchmark_runner.GetBenchmarkByName(name, config)
-  if not benchmark:
-    raise ValueError('No such benchmark: %s' % name)
-
+def FetchDepsForBenchmark(benchmark):
+  print 'Fetch dependencies for benchmark %s:' % benchmark.Name()

[laszio, 2017/06/01 18:48:44]

Some autotest tests in Chrome OS relies on the outputs (what's printed) of
fetch_benchmark_deps.py to further process the downloaded files. For example,
they do something like:

$ fetch_benchmark_deps.py blabla | xargs -I__FILES__ scp __FILES__ DUT

This will break the assumption / interface.

   # Download files according to specified benchmark.
   story_set = benchmark().CreateStorySet(None)
 
   _FetchDependenciesIfNeeded(story_set)
 
   # Print files downloaded.
   deps = _EnumerateDependencies(story_set)
   for dep in deps:
-    print >> output, dep
+    print dep
 
 
+def main(args):
+  parser = argparse.ArgumentParser(
+         description='Fetch the dependencies of perf benchmark(s).')
+  parser.add_argument('benchmark_name', type=str, nargs='?')
+  parser.add_argument('--force', '-f',
+                      help=('Force fetching all the benchmarks when '
+                            'benchmark_name is not specified'),
+                      action='store_true', default=False)
+
+  options = parser.parse_args(args)
+
+  if options.benchmark_name:
+    config = chromium_config.ChromiumConfig(
+        top_level_dir=path_util.GetPerfDir(),
+        benchmark_dirs=[os.path.join(path_util.GetPerfDir(), 'benchmarks')])
+    benchmark = benchmark_runner.GetBenchmarkByName(
+        options.benchmark_name, config)
+    if not benchmark:
+      raise ValueError('No such benchmark: %s' % options.benchmark_name)
+    FetchDepsForBenchmark(benchmark)
+  else:
+    if not options.force:
+      raw_input(
+          'No benchmark name is specified. Fetching all benchmark deps. '
+          'Press enter to continue...')

[laszio, 2017/06/01 18:48:44]

Same here. An easy workaround could be printing prompts to stderr. I can also
help change corresponding parts in autotest if you prefer defining a better
interface.

+    for b in benchmark_finders.GetAllBenchmarks():
+      FetchDepsForBenchmark(b)
+
 if __name__ == '__main__':
-  if len(sys.argv) != 2 or sys.argv[1][0] == '-':
-    _show_usage()
-  else:
-    main()
+  main(sys.argv[1:])