content/browser/web_contents/web_contents_impl.h - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Merge with ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/web_view.js ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 268749e5071c3446acea63a52b8248ac3c6fa0b8..640275896ddb6f26844af0934efe6f7234fee499 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -175,6 +175,7 @@ class CONTENT_EXPORT WebContentsImpl

virtual const GURL& GetLastCommittedURL() const OVERRIDE;

virtual RenderProcessHost* GetRenderProcessHost() const OVERRIDE;

virtual RenderFrameHost* GetMainFrame() OVERRIDE;

+ virtual void SetMainFrameName(const std::string& name) OVERRIDE;

virtual RenderFrameHost* GetFocusedFrame() OVERRIDE;

virtual void ForEachFrame(

const base::Callback<void(RenderFrameHost*)>& on_frame) OVERRIDE;

@@ -762,6 +763,9 @@ class CONTENT_EXPORT WebContentsImpl

const base::string16& sub_text);

void OnHideValidationMessage();

void OnMoveValidationMessage(const gfx::Rect& anchor_in_root_view);

+ void OnUpdateFrameName(int render_frame_id,

+ bool is_top_level,

+ const std::string& name);

// Called by derived classes to indicate that we're no longer waiting for a