content/browser/browser_plugin/browser_plugin_guest.h - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Merge with ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/web_view.js ('K') | « chrome/renderer/resources/extensions/web_view.js ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index b3466c0d143f9341c503817f877b81c55b14df98..eea7d7c9ca6a2ffda538f94eb4cd74db0e59d132 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -205,6 +205,9 @@ class CONTENT_EXPORT BrowserPluginGuest

const base::string16& frame_name,

const GURL& target_url,

WebContents* new_contents) OVERRIDE;

+ virtual void FrameNameChanged(int render_frame_id,

+ bool is_top_level,

+ const std::string& name) OVERRIDE;

virtual void RendererUnresponsive(WebContents* source) OVERRIDE;

virtual void RendererResponsive(WebContents* source) OVERRIDE;

virtual void RunFileChooser(WebContents* web_contents,

@@ -327,9 +330,6 @@ class CONTENT_EXPORT BrowserPluginGuest

int instance_id, const BrowserPluginHostMsg_ResizeGuest_Params& params);

// Overridden in tests.

virtual void OnSetFocus(int instance_id, bool focused);

- // Sets the name of the guest so that other guests in the same partition can

- // access it.

- void OnSetName(int instance_id, const std::string& name);

// Updates the size state of the guest.

void OnSetSize(

int instance_id,

@@ -397,9 +397,6 @@ class CONTENT_EXPORT BrowserPluginGuest

void OnShowWidget(int route_id, const gfx::Rect& initial_pos);

// Overridden in tests.

virtual void OnTakeFocus(bool reverse);

- void OnUpdateFrameName(int frame_id,

- bool is_top_level,

- const std::string& name);

void OnUpdateRect(const ViewHostMsg_UpdateRect_Params& params);

// Forwards all messages from the |pending_messages_| queue to the embedder.