content/public/renderer/render_frame_observer.h - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame_observer.h

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Addressed John's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/renderer/render_frame_observer.h

diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h

index c6e6609a991dd24b7bb04d7ec089dc0f2bd47970..9dd2de6e51a6b85c6d4017ee32dabd461f5db443 100644

--- a/content/public/renderer/render_frame_observer.h

+++ b/content/public/renderer/render_frame_observer.h

@@ -48,6 +48,7 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,

virtual void WillReleaseScriptContext(v8::Handle<v8::Context> context,

int world_id) {}

virtual void DidClearWindowObject() {}

+ virtual void DidChangeName(const base::string16& name) {}

// Called when we receive a console message from Blink for which we requested

// extra details (like the stack trace). |message| is the error message,

« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/browser_plugin/browser_plugin.h » ('j') | no next file with comments »