chrome/browser/guest_view/web_view/web_view_constants.cc - Issue 291483010: <webview>: Move name attribute to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_constants.cc

Issue 291483010: <webview>: Move name attribute to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newwindow_refactor

Patch Set: Addressed John's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_constants.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/web_view_constants.cc

diff --git a/chrome/browser/guest_view/web_view/web_view_constants.cc b/chrome/browser/guest_view/web_view/web_view_constants.cc

index 5c1e5f1c324997d4871d3e1d36446995af74f7bb..68be6a3ed556e9dcfa9d973afcc3475a99439201 100644

--- a/chrome/browser/guest_view/web_view/web_view_constants.cc

+++ b/chrome/browser/guest_view/web_view/web_view_constants.cc

@@ -14,6 +14,7 @@ const char kEventContextMenu[] = "webview.contextmenu";

const char kEventDialog[] = "webview.onDialog";

const char kEventExit[] = "webview.onExit";

const char kEventFindReply[] = "webview.onFindReply";

+const char kEventFrameNameChanged[] = "webview.onFrameNameChanged";

const char kEventLoadAbort[] = "webview.onLoadAbort";

const char kEventLoadCommit[] = "webview.onLoadCommit";

const char kEventLoadProgress[] = "webview.onLoadProgress";

« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_constants.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »