Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291483005: drive: Discard stream reader canceller as soon as the required data is obtained. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Discard stream reader canceller as soon as the required data is obtained. BUG=374058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -50 lines) Patch
M chrome/browser/chromeos/drive/drive_file_stream_reader.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc View 6 chunks +55 lines, -47 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kinaba
6 years, 7 months ago (2014-05-16 04:25:35 UTC) #1
hashimoto
lgtm
6 years, 7 months ago (2014-05-16 04:52:59 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-16 04:54:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/291483005/1
6 years, 7 months ago (2014-05-16 04:54:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 09:47:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 09:50:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154423)
6 years, 7 months ago (2014-05-16 09:50:57 UTC) #7
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-16 10:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/291483005/1
6 years, 7 months ago (2014-05-16 10:03:04 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 12:54:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 12:57:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154476)
6 years, 7 months ago (2014-05-16 12:57:46 UTC) #12
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-16 15:46:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/291483005/1
6 years, 7 months ago (2014-05-16 15:47:11 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:06:10 UTC) #15
Message was sent while issue was closed. 
Change committed as 271040

Powered by Google App Engine
This is Rietveld 408576698