Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 291483004: cros_chrome_sdk.py: Fallback to partial-metadata.json when needed. (Closed)

Created:
6 years, 7 months ago by davidjames
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

cros_chrome_sdk.py: Fallback to partial-metadata.json when needed. BUG=chromium:371079 TEST=cros chrome-sdk --internal --board lumpy --version=5854.0.0 now works Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270948

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
David James
6 years, 7 months ago (2014-05-16 01:39:50 UTC) #1
Ben Chan
lgtm
6 years, 7 months ago (2014-05-16 01:41:18 UTC) #2
David James
The CQ bit was checked by davidjames@google.com
6 years, 7 months ago (2014-05-16 01:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidjames@chromium.org/291483004/1
6 years, 7 months ago (2014-05-16 01:42:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 02:14:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 02:16:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/4847) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68042) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-16 02:16:37 UTC) #7
davidjames
The CQ bit was checked by davidjames@chromium.org
6 years, 7 months ago (2014-05-16 02:48:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidjames@chromium.org/291483004/20001
6 years, 7 months ago (2014-05-16 02:48:13 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 06:23:28 UTC) #10
Message was sent while issue was closed.
Change committed as 270948

Powered by Google App Engine
This is Rietveld 408576698