Issue 291483003: Only set title on SVG documents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291483003: Only set title on SVG documents (Closed)

Created:
6 years, 7 months ago by rwlbuis

Modified:
6 years, 7 months ago

Reviewers:
pdr., Stephen Chennney, kouhei (in TOK)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Only set title on SVG documents Only set title on SVG documents, HTML document should not be affected. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174123

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -6 lines)			Patch
A	LayoutTests/svg/custom/html-document-set-title.html	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/custom/html-document-set-title-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/svg/SVGTitleElement.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kouhei (in TOK)

On 2014/05/15 22:44:13, rwlbuis wrote: > PTAL. lgtm

6 years, 7 months ago (2014-05-16 01:33:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/291483003/1

6 years, 7 months ago (2014-05-16 02:05:19 UTC) #4

Message was sent while issue was closed.

Change committed as 174123

Expand Messages | Collapse Messages