Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 291483003: Only set title on SVG documents (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Only set title on SVG documents Only set title on SVG documents, HTML document should not be affected. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
A LayoutTests/svg/custom/html-document-set-title.html View 1 chunk +16 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/html-document-set-title-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGTitleElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL.
6 years, 7 months ago (2014-05-15 22:44:13 UTC) #1
kouhei (in TOK)
On 2014/05/15 22:44:13, rwlbuis wrote: > PTAL. lgtm
6 years, 7 months ago (2014-05-16 01:33:37 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-16 02:04:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/291483003/1
6 years, 7 months ago (2014-05-16 02:05:19 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 04:43:13 UTC) #5
Message was sent while issue was closed.
Change committed as 174123

Powered by Google App Engine
This is Rietveld 408576698