Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 291483002: CleanDeps() svn_deps_vars param is obsolete. (Closed)

Created:
6 years, 7 months ago by Michael Moss
Modified:
6 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, cmp-cc_chromium.org, szager1
Visibility:
Public.

Description

CleanDeps() svn_deps_vars param is obsolete. This was related to the DEPS_OVERRIDES handling that was removed in r270695 (and was never used in this method anyhow). R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M buildspec_to_git.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Moss
6 years, 7 months ago (2014-05-15 19:01:27 UTC) #1
DaleCurtis
lgtm, thanks!
6 years, 7 months ago (2014-05-15 19:17:21 UTC) #2
Michael Moss
6 years, 7 months ago (2014-05-15 19:36:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r270777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698