Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2914793006: Move local properties to KernelToLocalsMap (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -41 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 4 chunks +19 lines, -14 lines 1 comment Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 3 chunks +20 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 18 chunks +20 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 6 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-01 14:05:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2914793006/diff/1/pkg/compiler/lib/src/kernel/element_map.dart File pkg/compiler/lib/src/kernel/element_map.dart (left): https://codereview.chromium.org/2914793006/diff/1/pkg/compiler/lib/src/kernel/element_map.dart#oldcode159 pkg/compiler/lib/src/kernel/element_map.dart:159: // TODO(johnniwinther): Move these to a `KernelToLocalsMap`, maybe ...
3 years, 6 months ago (2017-06-01 22:13:41 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-02 09:42:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e28a2a32bdc8bfdc34d3702a0760b59c1432b633 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698