Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4257)

Unified Diff: chrome/installer/mac/BUILD.gn

Issue 2914783003: Copy variables.sh for all signing script targets. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/BUILD.gn
diff --git a/chrome/installer/mac/BUILD.gn b/chrome/installer/mac/BUILD.gn
index d6ad7cf1323343eda62a9fec350b658d51ba2251..5db362e2ed39dbb07b3cd0974697d5331ba2e11d 100644
--- a/chrome/installer/mac/BUILD.gn
+++ b/chrome/installer/mac/BUILD.gn
@@ -26,6 +26,10 @@ action("make_signers") {
script = "//build/gn_run_binary.py"
shell_script = "//chrome/installer/mac/make_signers.sh"
+ deps = [
+ ":copy_variables",
+ ]
+
inputs = [
script,
shell_script,
@@ -49,10 +53,20 @@ action("make_signers") {
]
}
+copy("copy_variables") {
Robert Sesek 2017/06/01 15:08:47 Add a visibility rule here: visibility = [ ":ma
Greg K 2017/06/01 18:35:14 Done.
+ sources = [
+ "variables.sh",
+ ]
+ outputs = [
+ "$_packaging_dir/{{source_file_part}}",
+ ]
+}
+
copy("copies") {
visibility = [ ":mac" ]
deps = [
+ ":copy_variables",
"//chrome/installer/mac/third_party/bsdiff:goobsdiff",
"//chrome/installer/mac/third_party/bsdiff:goobspatch",
"//chrome/installer/mac/third_party/xz:lzma_decompress",
@@ -71,7 +85,6 @@ copy("copies") {
"dmgdiffer.sh",
"pkg-dmg",
"sign_installer_tools.sh",
- "variables.sh",
]
if (is_chrome_branded) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698