Chromium Code Reviews| Index: components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc |
| diff --git a/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc b/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc |
| index 3c84ca5e937b4883abca3ce91a3b0e33a1b890bf..4c69137bf181f4cda2a629543644ddee9f8eeba3 100644 |
| --- a/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc |
| +++ b/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc |
| @@ -4,10 +4,20 @@ |
| #include "components/offline_pages/core/prefetch/prefetch_dispatcher_impl.h" |
| +#include "base/bind.h" |
| +#include "base/task_runner.h" |
| +#include "base/threading/thread_task_runner_handle.h" |
| #include "url/gurl.h" |
| namespace offline_pages { |
| +namespace { |
| +void DeleteBackgroundTaskHelper( |
| + std::unique_ptr<PrefetchDispatcher::ScopedBackgroundTask> task) { |
| + task.reset(); |
| +} |
| +} // namespace |
| + |
| PrefetchDispatcherImpl::PrefetchDispatcherImpl() {} |
| PrefetchDispatcherImpl::~PrefetchDispatcherImpl() = default; |
| @@ -28,11 +38,24 @@ void PrefetchDispatcherImpl::RemovePrefetchURLsByClientId( |
| void PrefetchDispatcherImpl::BeginBackgroundTask( |
| std::unique_ptr<ScopedBackgroundTask> task) { |
| - NOTIMPLEMENTED(); |
| + task_ = std::move(task); |
| } |
| -void PrefetchDispatcherImpl::StopBackgroundTask(ScopedBackgroundTask* task) { |
| - NOTIMPLEMENTED(); |
| +void PrefetchDispatcherImpl::StopBackgroundTask() { |
| + DisposeTask(); |
| +} |
| + |
| +void PrefetchDispatcherImpl::RequestFinishBackgroundTaskForTest() { |
| + DisposeTask(); |
| +} |
| + |
| +void PrefetchDispatcherImpl::DisposeTask() { |
| + if (!task_) |
|
dewittj
2017/06/01 00:22:27
Should this be DCHECK(task_) ?
jianli
2017/06/02 00:48:37
Done.
|
| + return; |
| + // Delay the deletion till the caller finishes. |
| + base::ThreadTaskRunnerHandle::Get()->PostTask( |
| + FROM_HERE, |
| + base::Bind(&DeleteBackgroundTaskHelper, base::Passed(std::move(task_)))); |
| } |
| } // namespace offline_pages |