Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: chrome/android/java/res/xml/account_management_preferences.xml

Issue 2914513002: Use explicit dividers between preferences in AccountManagementFragment (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/xml/account_management_preferences.xml
diff --git a/chrome/android/java/res/xml/account_management_preferences.xml b/chrome/android/java/res/xml/account_management_preferences.xml
index 4215dcba6ac4aa531b9544f7547feb07078d0463..b0f449a5aca9f977cae0b383f805f85579feb509 100644
--- a/chrome/android/java/res/xml/account_management_preferences.xml
+++ b/chrome/android/java/res/xml/account_management_preferences.xml
@@ -19,35 +19,57 @@
android:icon="@drawable/add_circle_blue"
android:order="1000" />
+ <Preference
+ android:layout="@layout/divider_preference"
+ android:order="1001" />
+
<PreferenceCategory
android:key="parental_settings"
android:title="@string/account_management_parental_settings"
- android:order="1001" />
+ android:order="1002" />
<org.chromium.chrome.browser.preferences.ChromeBasePreference
android:key="parent_accounts"
- android:order="1002" />
+ android:order="1003" />
<Preference
android:key="child_content"
android:title="@string/account_management_child_content_title"
- android:order="1003" />
+ android:order="1004" />
+
+ <Preference
+ android:key="child_content_divider"
+ android:layout="@layout/divider_preference"
+ android:order="1005" />
<org.chromium.chrome.browser.preferences.SyncPreference
android:key="sync_settings"
android:title="@string/sign_in_sync"
- android:order="1005"/>
+ android:order="1006" />
+
+ <Preference
+ android:layout="@layout/divider_preference"
+ android:order="1007" />
<Preference
android:key="google_activity_controls"
android:icon="@drawable/googleg"
android:title="@string/sign_in_google_activity_controls"
android:summary="@string/sign_in_google_activity_controls_message"
- android:order="1006" />
+ android:order="1008" />
+
+ <Preference
+ android:layout="@layout/divider_preference"
+ android:order="1009" />
<Preference
android:key="sign_out"
android:title="@string/account_management_sign_out"
- android:order="1007"/>
+ android:order="1010" />
+
+ <Preference
+ android:key="sign_out_divider"
+ android:layout="@layout/divider_preference"
+ android:order="1011" />
</PreferenceScreen>
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698