Issue 2914483002: Revert "Fix misoptimization of 'is' test"

Issue 2914483002: Revert "Fix misoptimization of 'is' test" (Closed)

Created:
3 years, 6 months ago by erikcorry

Modified:
3 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix misoptimization of 'is' test" R=johnniwinther@google.com BUG= This really reverts commit b7797ac45fe6d58d5dae6c4db3094afb1dfaa4bc code review at https://codereview.chromium.org/2904543002. Revert is due to an AOT failure. Committed: https://github.com/dart-lang/sdk/commit/2a5fa6441e1749ebd2159b4dbc3fe40654e7afb1

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+140 lines, -215 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	3 chunks	+69 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_dbc.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/jit_optimizer.cc	View	3 chunks	+56 lines, -3 lines	0 comments	Download
D	runtime/vm/optimizer.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	runtime/vm/optimizer.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	tests/standalone/regress_29695_test.dart	View	1 chunk	+0 lines, -28 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 6 months ago (2017-05-29 13:56:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a5fa6441e1749ebd2159b4dbc3fe40654e7afb1 (presubmit successful).