Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: components/arc/common/file_system.mojom

Issue 2914433002: arc: Use the MIME type returned by the container to handle content URLs (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/file_system.mojom
diff --git a/components/arc/common/file_system.mojom b/components/arc/common/file_system.mojom
index 24e4041ff8d137bc018b0cd52572b8b03c543433..6f0005fcc94afc5aa96a0b2af275c7d5269b27ac 100644
--- a/components/arc/common/file_system.mojom
+++ b/components/arc/common/file_system.mojom
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Next MinVersion: 4
+// Next MinVersion: 5
module arc.mojom;
@@ -51,7 +51,7 @@ interface FileSystemHost {
[MinVersion=3] OnDocumentChanged@0(int64 watcher_id, ChangeType type);
};
-// Next method ID: 8
+// Next method ID: 9
interface FileSystemInstance {
// Notes about Android Documents Provider:
//
@@ -105,6 +105,11 @@ interface FileSystemInstance {
// streams), -1 is returned.
[MinVersion=1] GetFileSize@1(string url) => (int64 size);
+ // Asks the ContentResolver to get the MIME type of the file specified by the
+ // URL. When an error occurs, returns null value (not to be confused with the
+ // empty string).
mtomasz 2017/06/05 04:29:55 optional: How are directories handled? On Android
hashimoto 2017/06/05 04:55:37 Android-side impl just calls ContentResolver.getTy
mtomasz 2017/06/05 05:01:06 SGTM, thanks for explanation.
+ [MinVersion=4] GetMimeType@8(string url) => (string? mime_type);
+
// Establishes full-duplex communication with the host.
[MinVersion=3] Init@5(FileSystemHost host_ptr);

Powered by Google App Engine
This is Rietveld 408576698