arc: Use the MIME type returned by the container to handle content URLs

chrome/browser/chromeos/file_manager/filesystem_api_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/filesystem_api_util.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/files/file.h"
 #include "base/files/file_path.h"
+#include "chrome/browser/chromeos/arc/arc_util.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_content_file_system_url_util.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/app_id.h"
 #include "chrome/browser/chromeos/file_manager/fileapi_util.h"
 #include "chrome/browser/chromeos/file_system_provider/mount_path_util.h"
 #include "chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
+#include "components/arc/arc_service_manager.h"
 #include "components/drive/chromeos/file_system_interface.h"
 #include "components/drive/file_errors.h"
 #include "components/drive/file_system_core_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/storage_partition.h"
 #include "google_apis/drive/task_util.h"
 #include "storage/browser/fileapi/file_system_context.h"
 
 namespace file_manager {
 namespace util {
@@ skipping 23 matching lines @@
     base::File::Error result) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   if (result != base::File::FILE_OK || !metadata->mime_type.get()) {
     callback.Run(false, std::string());
     return;
   }
   callback.Run(true, *metadata->mime_type);
 }
 
+// Helper function used to implement GetNonNativeLocalPathMimeType. It passes
+// the returned mime type to the callback.
+void GetMimeTypeAfterGetMimeTypeForArcContentFileSystem(
+    const base::Callback<void(bool, const std::string&)>& callback,
+    const base::Optional<std::string>& mime_type) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  if (mime_type.has_value()) {
+    callback.Run(true, mime_type.value());
+  } else {
+    callback.Run(false, std::string());
+  }
+}
+
 // Helper function to converts a callback that takes boolean value to that takes
 // File::Error, by regarding FILE_OK as the only successful value.
 void BoolCallbackAsFileErrorCallback(
     const base::Callback<void(bool)>& callback,
     base::File::Error error) {
   return callback.Run(error == base::File::FILE_OK);
 }
 
 // Part of PrepareFileOnIOThread. It tries to create a new file if the given
 // |url| is not already inhabited.
@@ skipping 60 matching lines @@
 
   storage::FileSystemURL filesystem_url =
       GetFileSystemContextForExtensionId(profile, kFileManagerAppId)
           ->CrackURL(url);
   if (!filesystem_url.is_valid())
     return false;
 
   return IsNonNativeFileSystemType(filesystem_url.type());
 }
 
 void GetNonNativeLocalPathMimeType(

[hidehiko, 2017/06/05 05:18:04]

Optional:
As this function gets bigger, and it looks to have a dup code, how about small
refactoring, like;

namespace {

bool GetNonNativeLocalPathMimeTypeInteranl(...) {
  if (IsUnderDriveMountPoint(...)) {
    auto* file_system = GetFileSystemByProfile(profile);
    if (!file_system)
      return false;
    ...
    return true;
  }

  if (IsFileSystemProviderLocalPath(...)) {
    ... parser ...
    if (!parser.Parse())
      return false;
    ...
    return true;
  }

  ... ditto  for your new code ...
  return false;
}

}  // namespace

void GetNonNativeLocalPathMimeType(...) {
  if (GetNonNativeLocalPathMimeType(...)) {
    // callback is deferred to the async operation, so do nothing.
    return;
  }
  // PostTask once to be consistent with async operation.
  PostTask(UI, FROM_HERE, BindOnce(callback, false, std::string()));
}

[hashimoto, 2017/06/05 05:40:52]

Thanks, sounds like a good thing to do when working on crbug.com/729442

     Profile* profile,
     const base::FilePath& path,
     const base::Callback<void(bool, const std::string&)>& callback) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK(IsUnderNonNativeLocalPath(profile, path));
 
   if (drive::util::IsUnderDriveMountPoint(path)) {
     drive::FileSystemInterface* file_system =
         drive::util::GetFileSystemByProfile(profile);
     if (!file_system) {
@@ skipping 21 matching lines @@
 
     parser.file_system()->GetMetadata(
         parser.file_path(),
         chromeos::file_system_provider::ProvidedFileSystemInterface::
             METADATA_FIELD_MIME_TYPE,
         base::Bind(&GetMimeTypeAfterGetMetadataForProvidedFileSystem,
                    callback));
     return;
   }
 
+  if (arc::IsArcAllowedForProfile(profile) &&
+      base::FilePath(arc::kContentFileSystemMountPointPath).IsParent(path)) {
+    GURL arc_url = arc::PathToArcUrl(path);
+    auto* runner = arc::ArcServiceManager::GetGlobalService<
+        arc::ArcFileSystemOperationRunner>();
+    if (!runner) {
+      content::BrowserThread::PostTask(
+          content::BrowserThread::UI, FROM_HERE,
+          base::BindOnce(callback, false, std::string()));
+      return;
+    }
+    runner->GetMimeType(
+        arc_url, base::Bind(&GetMimeTypeAfterGetMimeTypeForArcContentFileSystem,

[hidehiko, 2017/06/05 05:18:04]

style / optional: If you're starting to use BindOnce, this should be, too?
(Though, for consistency, we have more Bind() in this file to be converted to
BindOnce, I don't have strong opinion, in this CL).

[hashimoto, 2017/06/05 05:40:52]

Unfortunately, ArcFileSystemOperationRunner does not accept OnceCallback
(probably we should fix this) so we cannot use BindOnce here.

+                            callback));
+    return;
+  }
+
   // We don't have a way to obtain metadata other than drive and FSP. Returns an
   // error with empty MIME type, that leads fallback guessing mime type from
   // file extensions.
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::BindOnce(callback, false /* failure */, std::string()));
 }
 
 void IsNonNativeLocalPathDirectory(
     Profile* profile,
@@ skipping 34 matching lines @@
       backend->CreateInternalURL(file_system_context.get(), path);
 
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::BindOnce(&PrepareFileOnIOThread, file_system_context, internal_url,
                      google_apis::CreateRelayCallback(callback)));
 }
 
 }  // namespace util
 }  // namespace file_manager