Move LatencyInfo ipc traits from content/common/ to ui/events/ipc/

This CL moves the LatencyInfo's IPC traits from
content/common/content_param_traits_macros.h    to
ui/events/ipc/latency_info_param_traits

This way, code that wants to use LatencyInfo over IPC
don't have to depend on content/common, but a rather
smaller target events.gyp:events_ipc.

Also adds latency_info_nacl.gyp for a nacl build that
wants to use LatencyInfo over IPC.
 
BUG=355719
TEST=no functional change. Chrome builds.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271987

[sadrul, 2014-05-16 14:49:25]

https://codereview.chromium.org/291443006/diff/170001/ui/events/BUILD.gn
File ui/events/BUILD.gn (right):

https://codereview.chromium.org/291443006/diff/170001/ui/events/BUILD.gn#newc...
ui/events/BUILD.gn:17: component("events_ipc") {
Can this be in events/ipc/BUILD.gn?

https://codereview.chromium.org/291443006/diff/170001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/291443006/diff/170001/ui/events/events.gyp#ne...
ui/events/events.gyp:23: 'target_name': 'events_ipc',
Can this be in its own file in events/ipc/events_ipc.gyp?

[sadrul, 2014-05-16 14:50:15]

Also note that events/ipc/ should have an OWNERS file with noparent set, and
have the security folks listed.

[Yufeng Shen (Slow to review), 2014-05-16 17:13:13]

https://codereview.chromium.org/291443006/diff/170001/ui/events/BUILD.gn
File ui/events/BUILD.gn (right):

https://codereview.chromium.org/291443006/diff/170001/ui/events/BUILD.gn#newc...
ui/events/BUILD.gn:17: component("events_ipc") {
On 2014/05/16 14:49:26, sadrul wrote:
> Can this be in events/ipc/BUILD.gn?

Done.

https://codereview.chromium.org/291443006/diff/170001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/291443006/diff/170001/ui/events/events.gyp#ne...
ui/events/events.gyp:23: 'target_name': 'events_ipc',
On 2014/05/16 14:49:26, sadrul wrote:
> Can this be in its own file in events/ipc/events_ipc.gyp?

Done.

[Yufeng Shen (Slow to review), 2014-05-16 17:13:23]

On 2014/05/16 14:50:15, sadrul wrote:
> Also note that events/ipc/ should have an OWNERS file with noparent set, and
> have the security folks listed.

done.

[sadrul, 2014-05-20 17:18:31]

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/events_ip...
File ui/events/ipc/events_ipc.gyp (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/events_ip...
ui/events/ipc/events_ipc.gyp:15: '<(DEPTH)/ipc/ipc.gyp:ipc',
does this need a dep on events?

[jln (very slow on Chromium), 2014-05-20 17:45:10]

This lgtm. I don't have an opinion on the move, but I'm also not a good reviewer
for that.

Adding Tom in case he wants to chime in.

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
File ui/events/ipc/latency_info_param_traits.cc (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
ui/events/ipc/latency_info_param_traits.cc:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
No (c) in new files.

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
File ui/events/ipc/latency_info_param_traits.h (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
ui/events/ipc/latency_info_param_traits.h:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
No "(C)" in new files. Just "Copyright 2014"

[Tom Sepez, 2014-05-20 18:22:50]

Messages LGTM, but do we really need another ipc/ sub-directory? There isn't
going to be much in it.

[sadrul, 2014-05-20 18:28:55]

I suggested on a separate ipc/ directory to better clarify the ownership and
dependencies.

LGTM on non-ipc events changes (after jln@s nits addressed).

[Tom Sepez, 2014-05-20 18:31:09]

On 2014/05/20 18:28:55, sadrul wrote:
> I suggested on a separate ipc/ directory to better clarify the ownership and
> dependencies.
> 
Ok, you may be able to simplify the OWNERS file in that case.

[Yufeng Shen (Slow to review), 2014-05-20 18:32:33]

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/events_ip...
File ui/events/ipc/events_ipc.gyp (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/events_ip...
ui/events/ipc/events_ipc.gyp:15: '<(DEPTH)/ipc/ipc.gyp:ipc',
On 2014/05/20 17:18:32, sadrul wrote:
> does this need a dep on events?

It does not actually. The param traits only need to know the
declaration of LatencyInfo, and does not need to know any definition of events.

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
File ui/events/ipc/latency_info_param_traits.cc (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
ui/events/ipc/latency_info_param_traits.cc:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/05/20 17:45:11, jln wrote:
> No (c) in new files.

Done.

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
File ui/events/ipc/latency_info_param_traits.h (right):

https://codereview.chromium.org/291443006/diff/190001/ui/events/ipc/latency_i...
ui/events/ipc/latency_info_param_traits.h:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/05/20 17:45:11, jln wrote:
> No "(C)" in new files. Just "Copyright 2014"

Done.

[Tom Sepez, 2014-05-20 18:50:29]

LGTM on OWNERS changes.

[Yufeng Shen (Slow to review), 2014-05-20 18:56:26]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-05-20 18:57:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/291443006/270001

[commit-bot: I haz the power, 2014-05-20 19:39:17]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-20 19:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 19:43:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Yufeng Shen (Slow to review), 2014-05-20 20:18:52]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-05-20 20:20:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/291443006/290001

[commit-bot: I haz the power, 2014-05-20 21:03:18]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-20 21:05:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 21:05:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)

[Yufeng Shen (Slow to review), 2014-05-20 21:38:50]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-05-20 21:39:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/291443006/310001

[commit-bot: I haz the power, 2014-05-21 07:27:07]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-21 20:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:04:53]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Yufeng Shen (Slow to review), 2014-05-21 20:09:14]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-05-21 20:11:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/291443006/310001

[commit-bot: I haz the power, 2014-05-21 22:25:58]

Change committed as 271987