third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp - Issue 2914313002: Manage DOM and string offsets separately in TextIteratorTextState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

Issue 2914313002: Manage DOM and string offsets separately in TextIteratorTextState (Closed)

Patch Set: Fri Jun 2 10:34:55 PDT 2017 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

index d96e3c7053135e51d25b3563abad2137289ba393..1fd0e41dd2f3dcfc29478eca35c9d4f5162c609a 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp

@@ -330,7 +330,7 @@ void TextIteratorTextNodeHandler::HandleTextBox() {

// come back again to finish handling this text box; don't advance to

// the next one.

if (static_cast<unsigned>(text_state_->PositionEndOffset()) <

- text_box_end)

+ text_box_end + text_start_offset)

return;

if (behavior_.DoesNotEmitSpaceBeyondRangeEnd()) {