Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: ios/chrome/browser/ui/reading_list/offline_page_native_content_unittest.mm

Issue 2914303002: [ObjC ARC] Converts ios/chrome/browser/ui/reading_list:unit_tests to ARC. (Closed)
Patch Set: Use pragma to suppress performSelector ARC warning Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm » ('j') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/reading_list/offline_page_native_content.h" 5 #import "ios/chrome/browser/ui/reading_list/offline_page_native_content.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #import "base/mac/scoped_nsobject.h"
10 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
11 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h" 10 #include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
12 #include "ios/chrome/browser/reading_list/offline_url_utils.h" 11 #include "ios/chrome/browser/reading_list/offline_url_utils.h"
13 #import "ios/chrome/browser/ui/static_content/static_html_view_controller.h" 12 #import "ios/chrome/browser/ui/static_content/static_html_view_controller.h"
14 #import "ios/chrome/browser/ui/url_loader.h" 13 #import "ios/chrome/browser/ui/url_loader.h"
15 #import "ios/web/public/navigation_item.h" 14 #import "ios/web/public/navigation_item.h"
16 #import "ios/web/public/navigation_manager.h" 15 #import "ios/web/public/navigation_manager.h"
17 #import "ios/web/public/test/web_test_with_web_state.h" 16 #import "ios/web/public/test/web_test_with_web_state.h"
18 #import "ios/web/public/web_state/web_state.h" 17 #import "ios/web/public/web_state/web_state.h"
19 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
20 #include "testing/gtest_mac.h" 19 #include "testing/gtest_mac.h"
21 #import "third_party/ocmock/OCMock/OCMock.h" 20 #import "third_party/ocmock/OCMock/OCMock.h"
22 #include "third_party/ocmock/gtest_support.h" 21 #include "third_party/ocmock/gtest_support.h"
23 22
23 #if !defined(__has_feature) || !__has_feature(objc_arc)
24 #error "This file requires ARC support."
25 #endif
26
24 class OfflinePageNativeContentTest : public web::WebTestWithWebState { 27 class OfflinePageNativeContentTest : public web::WebTestWithWebState {
25 protected: 28 protected:
26 void SetUp() override { 29 void SetUp() override {
27 web::WebTestWithWebState::SetUp(); 30 web::WebTestWithWebState::SetUp();
28 TestChromeBrowserState::Builder test_cbs_builder; 31 TestChromeBrowserState::Builder test_cbs_builder;
29 chrome_browser_state_ = test_cbs_builder.Build(); 32 chrome_browser_state_ = test_cbs_builder.Build();
30 } 33 }
31 std::unique_ptr<TestChromeBrowserState> chrome_browser_state_; 34 std::unique_ptr<TestChromeBrowserState> chrome_browser_state_;
32 }; 35 };
33 36
34 // Checks the OfflinePageNativeContent is correctly initialized. 37 // Checks the OfflinePageNativeContent is correctly initialized.
35 TEST_F(OfflinePageNativeContentTest, BasicOfflinePageTest) { 38 TEST_F(OfflinePageNativeContentTest, BasicOfflinePageTest) {
36 GURL entry_url("http://foo.bar"); 39 GURL entry_url("http://foo.bar");
37 GURL distilled_url("http://foo.bar/distilled"); 40 GURL distilled_url("http://foo.bar/distilled");
38 GURL url = reading_list::OfflineURLForPath( 41 GURL url = reading_list::OfflineURLForPath(
39 base::FilePath("offline_id/page.html"), entry_url, distilled_url); 42 base::FilePath("offline_id/page.html"), entry_url, distilled_url);
40 id<UrlLoader> loader = [OCMockObject mockForProtocol:@protocol(UrlLoader)]; 43 id<UrlLoader> loader = [OCMockObject mockForProtocol:@protocol(UrlLoader)];
41 base::scoped_nsobject<OfflinePageNativeContent> content( 44 OfflinePageNativeContent* content = [[OfflinePageNativeContent alloc]
42 [[OfflinePageNativeContent alloc] 45 initWithLoader:loader
43 initWithLoader:loader 46 browserState:chrome_browser_state_.get()
44 browserState:chrome_browser_state_.get() 47 webState:web_state()
45 webState:web_state() 48 URL:url];
46 URL:url]);
47 ASSERT_EQ(url, [content url]); 49 ASSERT_EQ(url, [content url]);
48 ASSERT_EQ(distilled_url, [content virtualURL]); 50 ASSERT_EQ(distilled_url, [content virtualURL]);
49 ASSERT_OCMOCK_VERIFY((OCMockObject*)loader); 51 ASSERT_OCMOCK_VERIFY((OCMockObject*)loader);
50 } 52 }
51 53
52 // Checks that dismissing offline page restores EntryURL. 54 // Checks that dismissing offline page restores EntryURL.
53 TEST_F(OfflinePageNativeContentTest, DismissOfflineContent) { 55 TEST_F(OfflinePageNativeContentTest, DismissOfflineContent) {
54 GURL offline_url("http://foo.bar/offline"); 56 GURL offline_url("http://foo.bar/offline");
55 GURL entry_url("http://foo.bar/entry"); 57 GURL entry_url("http://foo.bar/entry");
56 GURL virtual_url("http://foo.bar/virtual"); 58 GURL virtual_url("http://foo.bar/virtual");
57 LoadHtml(@"<html></html>", offline_url); 59 LoadHtml(@"<html></html>", offline_url);
58 web::NavigationItem* item = 60 web::NavigationItem* item =
59 web_state()->GetNavigationManager()->GetLastCommittedItem(); 61 web_state()->GetNavigationManager()->GetLastCommittedItem();
60 item->SetURL(offline_url); 62 item->SetURL(offline_url);
61 item->SetVirtualURL(virtual_url); 63 item->SetVirtualURL(virtual_url);
62 64
63 GURL url = reading_list::OfflineURLForPath( 65 GURL url = reading_list::OfflineURLForPath(
64 base::FilePath("offline_id/page.html"), entry_url, virtual_url); 66 base::FilePath("offline_id/page.html"), entry_url, virtual_url);
65 id<UrlLoader> loader = [OCMockObject mockForProtocol:@protocol(UrlLoader)]; 67 id<UrlLoader> loader = [OCMockObject mockForProtocol:@protocol(UrlLoader)];
66 base::scoped_nsobject<OfflinePageNativeContent> content( 68 OfflinePageNativeContent* content = [[OfflinePageNativeContent alloc]
67 [[OfflinePageNativeContent alloc] 69 initWithLoader:loader
68 initWithLoader:loader 70 browserState:chrome_browser_state_.get()
69 browserState:chrome_browser_state_.get() 71 webState:web_state()
70 webState:web_state() 72 URL:url];
71 URL:url]);
72 ASSERT_EQ(url, [content url]); 73 ASSERT_EQ(url, [content url]);
73 ASSERT_EQ(virtual_url, [content virtualURL]); 74 ASSERT_EQ(virtual_url, [content virtualURL]);
74 ASSERT_OCMOCK_VERIFY((OCMockObject*)loader); 75 ASSERT_OCMOCK_VERIFY((OCMockObject*)loader);
75 [content willBeDismissed]; 76 [content willBeDismissed];
76 DCHECK_EQ(item->GetURL(), entry_url); 77 DCHECK_EQ(item->GetURL(), entry_url);
77 DCHECK_EQ(item->GetVirtualURL(), entry_url); 78 DCHECK_EQ(item->GetVirtualURL(), entry_url);
78 } 79 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/ui/reading_list/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm » ('j') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698