[IndexedDB] [DevTools] Right-click 'Refresh' on database now updates object store view, also fixed …

third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html

Index: third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html b/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html
index d9c3bb0df10d3ba4772291f7e19008ec823914bb..2c70dd563f31d45f00f3947422a07903a69cc6c6 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/database-refresh-view.html
@@ -87,6 +87,11 @@ async function test()
         view._refreshDatabaseButtonClicked();
     }
 
+    function waitRefreshDatabaseRightClick(callback) {
+        InspectorTest.addSniffer(Resources.IDBDataView.prototype, "_updatedDataForTests", callback, false);
+        idbDatabaseTreeElement._refreshIndexedDB();
+    }
+
     function waitUpdateDataView(callback) {
         InspectorTest.addSniffer(Resources.IDBDataView.prototype, "_updatedDataForTests", callback, false);
     }
@@ -174,7 +179,25 @@ async function test()
         }
     }
     await new Promise(waitUpdateDataView);      // Wait for objectstore data to load on page.
-    InspectorTest.addResult("Refreshed database.");
+    InspectorTest.addResult("Refreshed database view.");
+    dumpObjectStores();
+
+    // Add entries
+    await InspectorTest.evaluateInPageAsync("addIDBValue('" + databaseName + "', '" + objectStoreName2 + "', 'testKey2', 'testValue2')");

[dmurph, 2017/06/01 22:50:31]

Can you use this:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/test...

or create a different utility wrapper that uses promises?

[kristipark, 2017/06/02 00:16:56]

Since those function uses callbacks, I made the above promise based utility
functions instead (using InspectorTest.evaluateInPageAsync). Moved those
functions to indexeddb-test.js.

+    InspectorTest.addResult("Added " + objectStoreName2 + " entry.");
+    dumpObjectStores();
+
+    // Right-click refresh database view
+    await new Promise(waitRefreshDatabaseRightClick);
+    for (var i = 0; i < idbDatabaseTreeElement.childCount(); ++i) {
+        var objectStoreTreeElement = idbDatabaseTreeElement.childAt(i);
+        if (objectStoreTreeElement._objectStore.name === objectStoreName2) {
+            objectStoreTreeElement.onselect(false);

[dmurph, 2017/06/01 22:50:31]

Can you comment what this does? This selects the tree element, and opens that
view?

[kristipark, 2017/06/02 00:16:56]

Ah, you're right, it doesn't do anything. Removed!

+            break;
+        }
+    }
+    await new Promise(waitUpdateDataView);      // Wait for objectstore data to load on page.
+    InspectorTest.addResult("Right-click refreshed database.");
     dumpObjectStores();
 
     InspectorTest.completeTest();