[IndexedDB] [DevTools] Right-click 'Refresh' on database now updates object store view, also fixed …

third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 Resources.IDBDatabaseView = class extends UI.VBox {
   /**
    * @param {!Resources.IndexedDBModel} model
    * @param {!Resources.IndexedDBModel.Database} database
    */
   constructor(model, database) {
     super();
 
     this._model = model;
 
-    this._reportView = new UI.ReportView(database.databaseId.name);
+    var databaseName = 'Loading...';  // If database was not loaded yet when view was created

[dgozman, 2017/06/02 21:48:41]

We wrap any user-readable strings with Common.UIString call:
Common.UIString('Loading\u2026')

[kristipark, 2017/06/03 01:42:44]

Done.

+    if (database)
+      databaseName = database.databaseId.name;
+
+    this._reportView = new UI.ReportView(databaseName);
     this._reportView.show(this.contentElement);
 
     var bodySection = this._reportView.appendSection('');
     this._securityOriginElement = bodySection.appendField(Common.UIString('Security origin'));
     this._versionElement = bodySection.appendField(Common.UIString('Version'));
 
     var footer = this._reportView.appendSection('').appendRow();
     this._clearButton = UI.createTextButton(
         Common.UIString('Delete database'), () => this._deleteDatabase(), Common.UIString('Delete database'));
     footer.appendChild(this._clearButton);
@@ skipping 12 matching lines @@
   }
 
   _refreshDatabaseButtonClicked() {
     this._model.refreshDatabase(this._database.databaseId);
   }
 
   /**
    * @param {!Resources.IndexedDBModel.Database} database
    */
   update(database) {
-    this._database = database;
-    this._refreshDatabase();
+    if (database) {

[dgozman, 2017/06/02 21:48:41]

The database is marked as non-null in line 78. How come it could be null?

[kristipark, 2017/06/03 01:42:44]

The constructor calls update with a null database (line 65), so I added the null
check here. Went ahead and moved it to the constructor.

+      this._database = database;
+      this._reportView.setTitle(this._database.databaseId.name);
+      this._refreshDatabase();
+    }
     this._updatedForTests();
   }
 
   _updatedForTests() {
     // Sniffed in tests.
   }
 
   _deleteDatabase() {
     UI.ConfirmDialog.show(
         this.element, Common.UIString('Are you sure you want to delete "%s"?', this._database.databaseId.name),
@@ skipping 295 matching lines @@
         cell.removeChildren();
         var objectElement = ObjectUI.ObjectPropertiesSection.defaultObjectPresentation(value, undefined, true);
         cell.appendChild(objectElement);
         break;
       default:
     }
 
     return cell;
   }
 };