Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: runtime/observatory/lib/src/elements/native_memory_profiler.dart

Issue 2914283002: Observatory: (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/native_memory_profiler.dart
diff --git a/runtime/observatory/lib/src/elements/native_memory_profiler.dart b/runtime/observatory/lib/src/elements/native_memory_profiler.dart
index 2820afe90ab423032a7a402ad86d67a8c3394bcf..a2ea1bc4570306372b4894c7edf7f77730856f99 100644
--- a/runtime/observatory/lib/src/elements/native_memory_profiler.dart
+++ b/runtime/observatory/lib/src/elements/native_memory_profiler.dart
@@ -52,7 +52,7 @@ class NativeMemoryProfileElement extends HtmlElement implements Renderable {
M.NotificationRepository get notifications => _notifications;
M.NativeMemorySampleProfileRepository get profiles => _profiles;
// With non-isolate version.
- M.VMRef get vm => _vm;
+ M.VM get vm => _vm;
devoncarew 2017/06/01 21:12:20 Is this overriding something, or providing access
rmacnak 2017/06/01 21:25:56 I don't see other users, so removed. We can always
factory NativeMemoryProfileElement(
M.VM vm,
@@ -143,8 +143,8 @@ class NativeMemoryProfileElement extends HtmlElement implements Renderable {
}
Future _request({bool forceFetch: false}) async {
- for (Isolate isolate in vm.isolates) {
- await isolate.invokeRpc("_collectAllGarbage", {});
+ for (M.Isolate isolate in vm.isolates) {
+ await isolate.collectAllGarbage();
}
_progress = null;
_progressStream = _profiles.get(_vm, _tag, forceFetch: forceFetch);
« no previous file with comments | « runtime/observatory/lib/src/elements/heap_map.dart ('k') | runtime/observatory/lib/src/models/objects/isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698