Observatory:

Observatory:

 - Add M.Isolate.collectAllGarbage.
 - Add 'count' parameter to ObjectRepository.get.
 - Set hover text in heap map so it is usable when it doesn't fit on one page.

R=asiva@google.com, devoncarew@google.com

Committed: https://github.com/dart-lang/sdk/commit/2abda1fdd721a25d0b62d39b30c20069108e9ffb

[rmacnak, 2017-06-01 21:00:42]

rmacnak@google.com changed reviewers:
+ asiva@google.com, devoncarew@google.com

[devoncarew, 2017-06-01 21:12:20]

Changes look good, but I'm not really familiar enough here to lgtm :) One
comment about a no-longer-needed getter.

https://codereview.chromium.org/2914283002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/native_memory_profiler.dart (right):

https://codereview.chromium.org/2914283002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/native_memory_profiler.dart:55: M.VM get vm
=> _vm;
Is this overriding something, or providing access to code outside this library?
The getter's now ~the same as the _vm field.

(from a quick pass, it looks like neither; consider just removing the getter)

[siva, 2017-06-01 21:24:20]

lgtm

[rmacnak, 2017-06-01 21:25:56]

https://codereview.chromium.org/2914283002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/native_memory_profiler.dart (right):

https://codereview.chromium.org/2914283002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/native_memory_profiler.dart:55: M.VM get vm
=> _vm;
On 2017/06/01 21:12:20, devoncarew wrote:
> Is this overriding something, or providing access to code outside this
library?
> The getter's now ~the same as the _vm field.
> 
> (from a quick pass, it looks like neither; consider just removing the getter)

I don't see other users, so removed. We can always add it back later if needed.

[rmacnak, 2017-06-01 21:26:52]

Description was changed from

==========
Observatory:

 - Add M.Isolate.collectAllGarbage.
 - Add 'count' parameter to ObjectRepository.get.
 - Set hover text in heap map so it is usable when it doesn't fit on one page.
==========

to

==========
Observatory:

 - Add M.Isolate.collectAllGarbage.
 - Add 'count' parameter to ObjectRepository.get.
 - Set hover text in heap map so it is usable when it doesn't fit on one page.

R=asiva@google.com, devoncarew@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2abda1fdd721a25d0b62d39b30c20069108e9ffb
==========

[rmacnak, 2017-06-01 21:26:53]

Committed patchset #2 (id:20001) manually as
2abda1fdd721a25d0b62d39b30c20069108e9ffb (presubmit successful).