Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: components/ntp_snippets/breaking_news/subscription_manager_unittest.cc

Issue 2914263002: [NTP::Push] Adding Breaking News Subscription Manager (Closed)
Patch Set: Subscription endpoint as a parameter. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/breaking_news/subscription_manager.cc ('k') | components/ntp_snippets/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
diff --git a/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc b/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1cddf00af7bb04649b2fcf188bdd01e0e437f06f
--- /dev/null
+++ b/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
@@ -0,0 +1,85 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/breaking_news/subscription_manager.h"
+
+#include "base/message_loop/message_loop.h"
+#include "components/ntp_snippets/pref_names.h"
+#include "components/prefs/testing_pref_service.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ntp_snippets {
+
+class SubscriptionManagerTest : public testing::Test {
+ public:
+ SubscriptionManagerTest()
+ : request_context_getter_(
+ new net::TestURLRequestContextGetter(message_loop_.task_runner())),
+ pref_service_(base::MakeUnique<TestingPrefServiceSimple>()) {}
+
+ void SetUp() override {
+ SubscriptionManager::RegisterProfilePrefs(pref_service_->registry());
+ }
+
+ scoped_refptr<net::URLRequestContextGetter> GetRequestContext() {
+ return request_context_getter_.get();
+ }
+
+ PrefService* GetPrefService() { return pref_service_.get(); }
+
+ net::TestURLFetcher* GetRunningFetcher() {
+ // All created TestURLFetchers have ID 0 by default.
+ net::TestURLFetcher* url_fetcher = url_fetcher_factory_.GetFetcherByID(0);
+ DCHECK(url_fetcher);
+ return url_fetcher;
+ }
+
+ void RespondWithData(const std::string& data) {
+ net::TestURLFetcher* url_fetcher = GetRunningFetcher();
+ url_fetcher->set_status(net::URLRequestStatus());
+ url_fetcher->set_response_code(net::HTTP_OK);
+ url_fetcher->SetResponseString(data);
+ // Call the URLFetcher delegate to continue the test.
+ url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
+ }
+
+ void RespondWithError(int error_code) {
+ net::TestURLFetcher* url_fetcher = GetRunningFetcher();
+ url_fetcher->set_status(net::URLRequestStatus::FromError(error_code));
+ url_fetcher->SetResponseString(std::string());
+ // Call the URLFetcher delegate to continue the test.
+ url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
+ }
+
+ private:
+ base::MessageLoop message_loop_;
+ scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
+ net::TestURLFetcherFactory url_fetcher_factory_;
+ std::unique_ptr<TestingPrefServiceSimple> pref_service_;
+};
+
+TEST_F(SubscriptionManagerTest, SubscribeSuccessfully) {
+ std::string token = "1234567890";
+ SubscriptionManager manager(GetRequestContext(), GetPrefService(),
+ GURL("http://valid-url.test"));
+ manager.Subscribe(token);
+ RespondWithData("");
+ EXPECT_EQ(GetPrefService()->GetString(
+ ntp_snippets::prefs::kContentSuggestionsSubscriptionDataToken),
+ token);
+}
+
+TEST_F(SubscriptionManagerTest, SubscribeWithErrors) {
+ std::string token = "1234567890";
+ SubscriptionManager manager(GetRequestContext(), GetPrefService(),
+ GURL("http://valid-url.test"));
+ manager.Subscribe(token);
+ RespondWithError(net::ERR_TIMED_OUT);
+ EXPECT_FALSE(GetPrefService()->HasPrefPath(
+ ntp_snippets::prefs::kContentSuggestionsSubscriptionDataToken));
+}
+
+} // namespace ntp_snippets
« no previous file with comments | « components/ntp_snippets/breaking_news/subscription_manager.cc ('k') | components/ntp_snippets/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698