[NTP::Push] Adding Breaking News Subscription Manager

components/ntp_snippets/breaking_news/subscription_manager_unittest.cc

Index: components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
diff --git a/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc b/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f47bce61acf30ff9291d6b0d8c6be4f4192cce3a
--- /dev/null
+++ b/components/ntp_snippets/breaking_news/subscription_manager_unittest.cc
@@ -0,0 +1,85 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/ntp_snippets/breaking_news/subscription_manager.h"
+
+#include "base/message_loop/message_loop.h"
+#include "components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h"
+#include "components/ntp_snippets/pref_names.h"
+#include "components/prefs/testing_pref_service.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace ntp_snippets {
+
+class SubscriptionManagerTest : public testing::Test {
+ public:
+  SubscriptionManagerTest()
+      : request_context_getter_(
+            new net::TestURLRequestContextGetter(message_loop_.task_runner())),
+        pref_service_(base::MakeUnique<TestingPrefServiceSimple>()) {}
+
+  void SetUp() override {
+    BreakingNewsSuggestionsProvider::RegisterProfilePrefs(

[fhorschig, 2017/06/06 09:00:26]

This feels a little bit out of place in the Manager's test class.
Why can't we move this function to the Manager?

[mamir, 2017/06/06 14:05:23]

Done.

+        pref_service_->registry());
+  }
+
+  scoped_refptr<net::URLRequestContextGetter> GetRequestContext() {
+    return request_context_getter_.get();
+  }
+
+  PrefService* GetPrefService() { return pref_service_.get(); }
+
+  net::TestURLFetcher* GetRunningFetcher() {
+    // All created TestURLFetchers have ID 0 by default.
+    net::TestURLFetcher* url_fetcher = url_fetcher_factory_.GetFetcherByID(0);
+    DCHECK(url_fetcher);
+    return url_fetcher;
+  }
+
+  void RespondWithData(const std::string& data) {
+    net::TestURLFetcher* url_fetcher = GetRunningFetcher();
+    url_fetcher->set_status(net::URLRequestStatus());
+    url_fetcher->set_response_code(net::HTTP_OK);
+    url_fetcher->SetResponseString(data);
+    // Call the URLFetcher delegate to continue the test.
+    url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
+  }
+
+  void RespondWithError(int error_code) {
+    net::TestURLFetcher* url_fetcher = GetRunningFetcher();
+    url_fetcher->set_status(net::URLRequestStatus::FromError(error_code));
+    url_fetcher->SetResponseString(std::string());
+    // Call the URLFetcher delegate to continue the test.
+    url_fetcher->delegate()->OnURLFetchComplete(url_fetcher);
+  }
+
+ private:
+  base::MessageLoop message_loop_;
+  scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_;
+  net::TestURLFetcherFactory url_fetcher_factory_;
+  std::unique_ptr<TestingPrefServiceSimple> pref_service_;
+};
+
+TEST_F(SubscriptionManagerTest, SubscribeWithoutErrors) {

[fhorschig, 2017/06/06 09:00:26]

nit: s/SubscribeWithoutErrors/SubscribeSuccessfully
(negations are harder to read when skimming the class)

[mamir, 2017/06/06 14:05:23]

Done.

+  std::string token = "1234567890";
+  SubscriptionManager manager(GetRequestContext(), GetPrefService());
+  manager.Subscribe(token);
+  RespondWithData("");
+  EXPECT_EQ(GetPrefService()->GetString(
+                ntp_snippets::prefs::kContentSuggestionsSubscriptionToken),
+            token);
+}
+
+TEST_F(SubscriptionManagerTest, SubscribeWithErrors) {
+  std::string token = "1234567890";
+  SubscriptionManager manager(GetRequestContext(), GetPrefService());
+  manager.Subscribe(token);
+  RespondWithError(net::ERR_TIMED_OUT);
+  EXPECT_FALSE(GetPrefService()->HasPrefPath(
+      ntp_snippets::prefs::kContentSuggestionsSubscriptionToken));
+}
+
+}  // namespace ntp_snippets