[NTP::Push] Adding Breaking News Subscription Manager

components/ntp_snippets/breaking_news/breaking_news_suggestions_provider.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_BREAKING_NEWS_SUGGESTIONS_PROVIDER_H_
+#define COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_BREAKING_NEWS_SUGGESTIONS_PROVIDER_H_
+
+#include "components/prefs/pref_registry_simple.h"
+class PrefRegistrySimple;
+
+namespace ntp_snippets {
+
+class BreakingNewsSuggestionsProvider {

[fhorschig, 2017/06/06 09:00:26]

How about a class comment to describe what this provider does/will do?
(I nearly added the same comment as Bernhard again)

[mamir, 2017/06/06 14:05:23]

Acknowledged.

+ public:
+  static void RegisterProfilePrefs(PrefRegistrySimple* registry);

[fhorschig, 2017/06/06 09:00:26]

Are you absolutely sure you will use the pref you register in this class?
If not, this function would feel way more at home in the Manager.
Your tests show it pretty nicely: You need this class 
(which will likely be on a higher layer) to even use Manager properly.

(If you don't need the pref in this very class but know that this class
will introduce more prefs, you can call a Manager's static function
within the implementation of this class.)

[mamir, 2017/06/06 14:05:23]

OK, I will remove to the manager.

+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(BreakingNewsSuggestionsProvider);
+};
+
+}  // namespace ntp_snippets
+#endif  // COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_BREAKING_NEWS_SUGGESTIONS_PROVIDER_H_