Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2914233002: Allow test.py to run dartdoc tests. Run dartdoc tests on pub bots. (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow test.py to run dartdoc tests. Run dartdoc tests on pub bots. BUG= R=jcollins@google.com Committed: https://github.com/dart-lang/sdk/commit/e161ad12ac472a17012be239d828c11979b2f337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/bots/pub.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
3 years, 6 months ago (2017-06-01 16:42:42 UTC) #2
jcollins
This LGTM but be warned that the tests won't pass right away.
3 years, 6 months ago (2017-06-01 16:52:01 UTC) #3
Bill Hesse
3 years, 6 months ago (2017-06-01 16:53:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e161ad12ac472a17012be239d828c11979b2f337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698