ios/chrome/browser/ui/toolbar/BUILD.gn - Issue 2914193002: [iOS] Factor out the KeyboardAccessoryView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/toolbar/BUILD.gn

Issue 2914193002: [iOS] Factor out the KeyboardAccessoryView. (Closed)

Patch Set: Addressed comments and broke retain cycle. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/toolbar/BUILD.gn

diff --git a/ios/chrome/browser/ui/toolbar/BUILD.gn b/ios/chrome/browser/ui/toolbar/BUILD.gn

index 32b6c41f6d8b0ffc700ea151fca937fa79f364c0..9bc5dfcb2d8ab2c9fea49583bd88e3060b7b93ce 100644

--- a/ios/chrome/browser/ui/toolbar/BUILD.gn

+++ b/ios/chrome/browser/ui/toolbar/BUILD.gn

@@ -40,6 +40,8 @@ bundle_data("resources") {

source_set("toolbar") {

configs += [ "//build/config/compiler:enable_arc" ]

sources = [

+ "keyboard_accessory_view.h",

+ "keyboard_accessory_view.mm",

"new_tab_button.h",

"new_tab_button.mm",

"toolbar_button_tints.h",

« no previous file with comments | « no previous file | ios/chrome/browser/ui/toolbar/keyboard_accessory_view.h » ('j') | no next file with comments »