Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2914163004: Omnibox UI Experiments: Make suggestions dropdown match omnibox width. (Closed)
Patch Set: Merge remote-tracking branch 'refs/remotes/origin/master' into 024-omnibox-width-views Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/browser/omnibox_field_trial.h" 5 #include "components/omnibox/browser/omnibox_field_trial.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 84
85 // Feature used to display the title of the current URL match. 85 // Feature used to display the title of the current URL match.
86 const base::Feature kDisplayTitleForCurrentUrl{ 86 const base::Feature kDisplayTitleForCurrentUrl{
87 "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_DISABLED_BY_DEFAULT}; 87 "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_DISABLED_BY_DEFAULT};
88 88
89 // Feature used for the max autocomplete matches UI experiment. 89 // Feature used for the max autocomplete matches UI experiment.
90 const base::Feature kUIExperimentMaxAutocompleteMatches{ 90 const base::Feature kUIExperimentMaxAutocompleteMatches{
91 "OmniboxUIExperimentMaxAutocompleteMatches", 91 "OmniboxUIExperimentMaxAutocompleteMatches",
92 base::FEATURE_DISABLED_BY_DEFAULT}; 92 base::FEATURE_DISABLED_BY_DEFAULT};
93 93
94 // Feature used for the omnibox narrow suggestions dropdown UI experiment.
95 const base::Feature kUIExperimentNarrowDropdown{
96 "OmniboxUIExperimentNarrowDropdown", base::FEATURE_DISABLED_BY_DEFAULT};
97
94 // Feature used for the vertical margin UI experiment. 98 // Feature used for the vertical margin UI experiment.
95 const base::Feature kUIExperimentVerticalLayout{ 99 const base::Feature kUIExperimentVerticalLayout{
96 "OmniboxUIExperimentVerticalLayout", base::FEATURE_DISABLED_BY_DEFAULT}; 100 "OmniboxUIExperimentVerticalLayout", base::FEATURE_DISABLED_BY_DEFAULT};
97 101
98 // Feature used for the vertical margin UI experiment. 102 // Feature used for the vertical margin UI experiment.
99 const base::Feature kUIExperimentVerticalMargin{ 103 const base::Feature kUIExperimentVerticalMargin{
100 "OmniboxUIExperimentVerticalMargin", base::FEATURE_DISABLED_BY_DEFAULT}; 104 "OmniboxUIExperimentVerticalMargin", base::FEATURE_DISABLED_BY_DEFAULT};
101 105
102 } // namespace omnibox 106 } // namespace omnibox
103 107
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 if (it != params.end()) 841 if (it != params.end())
838 return it->second; 842 return it->second;
839 // Fall back to the global instant extended context. 843 // Fall back to the global instant extended context.
840 it = params.find(rule + ":" + page_classification_str + ":*"); 844 it = params.find(rule + ":" + page_classification_str + ":*");
841 if (it != params.end()) 845 if (it != params.end())
842 return it->second; 846 return it->second;
843 // Look up rule in the global context. 847 // Look up rule in the global context.
844 it = params.find(rule + ":*:*"); 848 it = params.find(rule + ":*:*");
845 return (it != params.end()) ? it->second : std::string(); 849 return (it != params.end()) ? it->second : std::string();
846 } 850 }
OLDNEW
« no previous file with comments | « components/omnibox/browser/omnibox_field_trial.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698