Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Side by Side Diff: components/omnibox/browser/omnibox_field_trial.cc

Issue 2914163004: Omnibox UI Experiments: Make suggestions dropdown match omnibox width. (Closed)
Patch Set: fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/omnibox/browser/omnibox_field_trial.h" 5 #include "components/omnibox/browser/omnibox_field_trial.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 79
80 // Feature used to display the title of the current URL match. 80 // Feature used to display the title of the current URL match.
81 const base::Feature kDisplayTitleForCurrentUrl{ 81 const base::Feature kDisplayTitleForCurrentUrl{
82 "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_DISABLED_BY_DEFAULT}; 82 "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_DISABLED_BY_DEFAULT};
83 83
84 // Feature used for the max autocomplete matches UI experiment. 84 // Feature used for the max autocomplete matches UI experiment.
85 const base::Feature kUIExperimentMaxAutocompleteMatches{ 85 const base::Feature kUIExperimentMaxAutocompleteMatches{
86 "OmniboxUIExperimentMaxAutocompleteMatches", 86 "OmniboxUIExperimentMaxAutocompleteMatches",
87 base::FEATURE_DISABLED_BY_DEFAULT}; 87 base::FEATURE_DISABLED_BY_DEFAULT};
88 88
89 // Feature used for the omnibox suggestions dropdown width UI experiment.
90 const base::Feature kUIExperimentSuggestionsDropdownWidth{
91 "OmniboxUIExperimentSuggestionsDropdownWidth",
92 base::FEATURE_DISABLED_BY_DEFAULT};
93
89 // Feature used for the vertical margin UI experiment. 94 // Feature used for the vertical margin UI experiment.
90 const base::Feature kUIExperimentVerticalLayout{ 95 const base::Feature kUIExperimentVerticalLayout{
91 "OmniboxUIExperimentVerticalLayout", base::FEATURE_DISABLED_BY_DEFAULT}; 96 "OmniboxUIExperimentVerticalLayout", base::FEATURE_DISABLED_BY_DEFAULT};
92 97
93 // Feature used for the vertical margin UI experiment. 98 // Feature used for the vertical margin UI experiment.
94 const base::Feature kUIExperimentVerticalMargin{ 99 const base::Feature kUIExperimentVerticalMargin{
95 "OmniboxUIExperimentVerticalMargin", base::FEATURE_DISABLED_BY_DEFAULT}; 100 "OmniboxUIExperimentVerticalMargin", base::FEATURE_DISABLED_BY_DEFAULT};
96 101
97 } // namespace omnibox 102 } // namespace omnibox
98 103
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 if (it != params.end()) 837 if (it != params.end())
833 return it->second; 838 return it->second;
834 // Fall back to the global instant extended context. 839 // Fall back to the global instant extended context.
835 it = params.find(rule + ":" + page_classification_str + ":*"); 840 it = params.find(rule + ":" + page_classification_str + ":*");
836 if (it != params.end()) 841 if (it != params.end())
837 return it->second; 842 return it->second;
838 // Look up rule in the global context. 843 // Look up rule in the global context.
839 it = params.find(rule + ":*:*"); 844 it = params.find(rule + ":*:*");
840 return (it != params.end()) ? it->second : std::string(); 845 return (it != params.end()) ? it->second : std::string();
841 } 846 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698