Omnibox UI Experiments: Make suggestions dropdown match omnibox width.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 2964 matching lines @@
      FEATURE_WITH_PARAMS_VALUE_TYPE(
          omnibox::kUIExperimentMaxAutocompleteMatches,
          kOmniboxUIMaxAutocompleteMatchesVariations,
          "OmniboxUIMaxAutocompleteVariations")},
 
     {"omnibox-ui-vertical-layout",
      flag_descriptions::kOmniboxUIVerticalLayoutName,
      flag_descriptions::kOmniboxUIVerticalLayoutDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(omnibox::kUIExperimentVerticalLayout)},
 
+    {"omnibox-ui-suggestions-dropdown-width",

[Peter Kasting, 2017/06/05 18:25:44]

Nit: The name of the flag/associated variables sound like they'll take a width
arg:

  --omnibox-blah-width=357

You might consider something like "omnibox-ui-narrow-dropdown" instead, which
doesn't sound like it requires an argument (to me).

[tommycli, 2017/06/05 22:39:20]

Done.

+     flag_descriptions::kOmniboxUISuggestionsDropdownWidthName,
+     flag_descriptions::kOmniboxUISuggestionsDropdownWidthDescription,
+     kOsDesktop,
+     FEATURE_VALUE_TYPE(omnibox::kUIExperimentSuggestionsDropdownWidth)},
+
     {"omnibox-ui-vertical-margin",
      flag_descriptions::kOmniboxUIVerticalMarginName,
      flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop,
      FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperimentVerticalMargin,
                                     kOmniboxUIVerticalMarginVariations,
                                     "OmniboxUIVerticalMarginVariations")},
 
     {"use-suggestions-even-if-few",
      flag_descriptions::kUseSuggestionsEvenIfFewFeatureName,
      flag_descriptions::kUseSuggestionsEvenIfFewFeatureDescription, kOsAll,
@@ skipping 263 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags