Check that Diagnostic subclasses are registered in presubmit.

tracing/tracing_project.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 import os
 import re
 
 
 def _AddToPathIfNeeded(path):
@@ skipping 69 matching lines @@
 
   ui_path = os.path.join(tracing_src_path, 'ui')
   d3_path = os.path.join(tracing_third_party_path, 'd3')
   chai_path = os.path.join(tracing_third_party_path, 'chai')
   mocha_path = os.path.join(tracing_third_party_path, 'mocha')
   oboe_path = os.path.join(tracing_third_party_path, 'oboe')
 
   mre_path = os.path.join(tracing_src_path, 'mre')
 
   metrics_path = os.path.join(tracing_src_path, 'metrics')
+  diagnostics_path = os.path.join(tracing_src_path, 'value', 'diagnostics')
 
   value_ui_path = os.path.join(tracing_src_path, 'value', 'ui')
   metrics_ui_path = os.path.join(tracing_src_path, 'metrics', 'ui')
 
   test_data_path = os.path.join(tracing_root_path, 'test_data')
   skp_data_path = os.path.join(tracing_root_path, 'skp_data')
 
   rjsmin_path = os.path.join(
       tracing_third_party_path, 'tvcm', 'third_party', 'rjsmin')
   rcssmin_path = os.path.join(
@@ skipping 44 matching lines @@
   def FindAllMetricsModuleRelPaths(self):
     all_filenames = _FindAllFilesRecursive([self.tracing_src_path])
     all_metrics_module_filenames = []
     for x in all_filenames:
       if x.startswith(self.metrics_path) and not _IsFilenameATest(x):
         all_metrics_module_filenames.append(x)
     all_metrics_module_filenames.sort()
     return [os.path.relpath(x, self.tracing_root_path)
             for x in all_metrics_module_filenames]
 
+  def FindAllDiagnosticsModuleRelPaths(self):
+    all_filenames = _FindAllFilesRecursive([self.tracing_src_path])
+    all_diagnostics_module_filenames = []
+    for x in all_filenames:
+      if x.startswith(self.diagnostics_path) and not _IsFilenameATest(x):
+        all_diagnostics_module_filenames.append(x)
+    all_diagnostics_module_filenames.sort()
+    return [os.path.relpath(x, self.tracing_root_path)
+            for x in all_diagnostics_module_filenames]
+
   def FindAllD8TestModuleRelPaths(self):
     return self.FindAllTestModuleRelPaths(pred=self.IsD8CompatibleFile)
 
   def GetConfigNames(self):
     config_files = [
         os.path.join(self.ui_extras_path, x)
         for x in os.listdir(self.ui_extras_path)
         if x.endswith('_config.html')
     ]
 
@@ skipping 12 matching lines @@
     choices = self.GetConfigNames()
     parser.add_argument(
         '--config', dest='config_name',
         choices=choices, default=self.GetDefaultConfigName(),
         help='Picks a browser config. Valid choices: %s' % ', '.join(choices))
     return choices
 
   def GetModuleNameForConfigName(self, config_name):
     return 'tracing.ui.extras.%s_config' % config_name