Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2914143002: Disable some tests that shouldn't run on platforms without dart:mirrors. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 6 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable some tests that shouldn't run on platforms without dart:mirrors. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/a783fdc44cd3a7835d66c4f4cbbdd9aa0eafc647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tests/standalone/standalone.status View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
3 years, 6 months ago (2017-06-01 00:10:22 UTC) #2
Emily Fortuna
lgtm. I applaud your inline commenting.
3 years, 6 months ago (2017-06-01 00:13:56 UTC) #3
Bob Nystrom
3 years, 6 months ago (2017-06-01 00:14:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a783fdc44cd3a7835d66c4f4cbbdd9aa0eafc647 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698