Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart

Issue 2914093002: Remove some bogus type promotion code. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/kompile.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart b/pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart
index 80229e9c0f6d1324c67e729cacf31626cc8016d6..4f90dbd818da0ec2687d5ee83d66fe5a81ad4442 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart
@@ -206,9 +206,7 @@ abstract class TypePromoterImpl<E, V> extends TypePromoter<E, V> {
_computeCurrentFactMap()[variable],
functionNestingLevel,
type);
- if (isInverted) {
- _recordPromotionExpression(isExpression, _currentFacts, isCheck);
- } else {
+ if (!isInverted) {
_recordPromotionExpression(isExpression, isCheck, _currentFacts);
}
}
« no previous file with comments | « no previous file | pkg/front_end/test/fasta/kompile.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698