Settings: Network: Closure cleanup

chrome/browser/resources/settings/internet_page/internet_subpage.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Polymer element for displaying information about WiFi,
  * WiMAX, or virtual networks.
  */
 
-/** @typedef {chrome.networkingPrivate.DeviceStateProperties} */
-var DeviceStateProperties;
-
 Polymer({
   is: 'settings-internet-subpage',
 
   behaviors: [
     CrPolicyNetworkBehavior,
     settings.RouteObserverBehavior,
     I18nBehavior,
   ],
 
   properties: {
     /**
      * Highest priority connected network or null. Provided by
      * settings-internet-page (but set in network-summary).
      * @type {?CrOnc.NetworkStateProperties|undefined}
      */
     defaultNetwork: Object,
 
     /**
      * Device state for the network type.
-     * @type {?DeviceStateProperties}
+     * @type {!CrOnc.DeviceStateProperties|undefined}
      */
-    deviceState: {
-      type: Object,
-      value: null,
-    },
+    deviceState: Object,
 
     /** @type {!chrome.networkingPrivate.GlobalPolicy|undefined} */
     globalPolicy: Object,
 
     /**
      * List of third party VPN providers.
      * @type
      *     {!Array<!chrome.networkingPrivate.ThirdPartyVPNProperties>|undefined}
      */
     thirdPartyVpnProviders: Array,
@@ skipping 149 matching lines @@
         } else {
           networkStateList.push(state);
         }
       }
       this.networkStateList_ = networkStateList;
       this.thirdPartyVpns_ = thirdPartyVpns;
     }.bind(this));
   },
 
   /**
-   * @param {!DeviceStateProperties|undefined} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @return {boolean} Whether or not the device state is enabled.
    * @private
    */
   deviceIsEnabled_: function(deviceState) {
-    return !!deviceState &&
-        deviceState.State == chrome.networkingPrivate.DeviceStateType.ENABLED;
+    return !!deviceState && deviceState.State == CrOnc.DeviceState.ENABLED;
   },
 
   /**
-   * @param {!DeviceStateProperties|undefined} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @param {string} onstr
    * @param {string} offstr
    * @return {string}
    * @private
    */
   getOffOnString_: function(deviceState, onstr, offstr) {
     return this.deviceIsEnabled_(deviceState) ? onstr : offstr;
   },
 
   /**
-   * @param {?DeviceStateProperties} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @return {boolean}
    * @private
    */
   enableToggleIsVisible_: function(deviceState) {
     return !!deviceState && deviceState.Type != CrOnc.Type.ETHERNET &&
         deviceState.Type != CrOnc.Type.VPN;
   },
 
   /**
-   * @param {?DeviceStateProperties} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @return {boolean}
    * @private
    */
   enableToggleIsEnabled_: function(deviceState) {
-    return !!deviceState &&
-        deviceState.State !=
-        chrome.networkingPrivate.DeviceStateType.PROHIBITED;
+    return !!deviceState && deviceState.State != CrOnc.DeviceState.PROHIBITED;
   },
 
   /**
-   * @param {!DeviceStateProperties} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @return {string}
    * @private
    */
   getToggleA11yString_: function(deviceState) {
     if (!this.enableToggleIsVisible_(deviceState))
       return '';
     switch (deviceState.Type) {
       case CrOnc.Type.TETHER:
         return this.i18n('internetToggleTetherA11yLabel');
       case CrOnc.Type.CELLULAR:
@@ skipping 19 matching lines @@
   /**
    * @param {!chrome.networkingPrivate.GlobalPolicy} globalPolicy
    * @return {boolean}
    * @private
    */
   allowAddConnection_: function(globalPolicy) {
     return globalPolicy && !globalPolicy.AllowOnlyPolicyNetworksToConnect;
   },
 
   /**
-   * @param {!DeviceStateProperties} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @param {!chrome.networkingPrivate.GlobalPolicy} globalPolicy
    * @return {boolean}
    * @private
    */
   showAddButton_: function(deviceState, globalPolicy) {
     if (!deviceState || deviceState.Type != CrOnc.Type.WI_FI)
       return false;
     if (!this.deviceIsEnabled_(deviceState))
       return false;
     return this.allowAddConnection_(globalPolicy);
@@ skipping 13 matching lines @@
    *              !{item: !chrome.networkingPrivate.ThirdPartyVPNProperties},
    *        }} event
    * @private
    */
   onAddThirdPartyVpnTap_: function(event) {
     var provider = event.model.item;
     chrome.send('addNetwork', [CrOnc.Type.VPN, provider.ExtensionID]);
   },
 
   /**
-   * @param {!DeviceStateProperties} deviceState
+   * @param {!CrOnc.DeviceStateProperties|undefined} deviceState
    * @return {boolean}
    * @private
    */
   knownNetworksIsVisible_: function(deviceState) {
-    return deviceState && deviceState.Type == CrOnc.Type.WI_FI;
+    return !!deviceState && deviceState.Type == CrOnc.Type.WI_FI;
   },
 
   /**
    * Event triggered when the known networks button is tapped.
    * @private
    */
   onKnownNetworksTap_: function() {
     assert(this.deviceState.Type == CrOnc.Type.WI_FI);
     this.fire('show-known-networks', {Type: this.deviceState.Type});
   },
@@ skipping 76 matching lines @@
 
   /**
    * @param {*} lhs
    * @param {*} rhs
    * @return {boolean}
    */
   isEqual_: function(lhs, rhs) {
     return lhs === rhs;
   },
 });