Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5681)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 291403002: Remove some RenderProcessHost::IsGuest call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More call sites removed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/prerender/prerender_link_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index 868d8da867c5b80d16d9429d9243820dc4473459..b6b9dbc66958689f1e534e87c388d9537c35493f 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -163,7 +163,10 @@ void RenderViewHostTargetsUIHandler::UpdateTargets() {
// Revisit this when multiple OOP frames are supported.
RenderFrameHost* rfh = rvh->GetMainFrame();
rfh_to_descriptor[rfh] = descriptor;
- if (rvh->GetProcess()->IsGuest() || rfh->IsCrossProcessSubframe()) {
+ content::WebContents* web_contents =
+ content::WebContents::FromRenderViewHost(rvh);
+ if (!!GuestViewBase::FromWebContents(web_contents) ||
lazyboy 2014/05/23 15:20:13 As noted offline, add a more obvious bool GuestVie
Fady Samuel 2014/05/23 15:35:59 Done.
+ rfh->IsCrossProcessSubframe()) {
nested_frames.push_back(rfh);
} else {
list_value->Append(descriptor);
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/prerender/prerender_link_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698