Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: ui/latency/mojo/struct_traits_unittest.cc

Issue 2914023002: Remove LatencyInfo::sequence_number. (May break metrics).
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/latency/mojo/struct_traits_unittest.cc
diff --git a/ui/latency/mojo/struct_traits_unittest.cc b/ui/latency/mojo/struct_traits_unittest.cc
index 2dbcc3a246d78d3b668724b92c08cd0b642d5205..98dcf9a045dff9e7453c2fd1764c361624d0a704 100644
--- a/ui/latency/mojo/struct_traits_unittest.cc
+++ b/ui/latency/mojo/struct_traits_unittest.cc
@@ -51,17 +51,14 @@ class StructTraitsTest : public testing::Test, public mojom::TraitsTestService {
} // namespace
TEST_F(StructTraitsTest, LatencyComponent) {
- const int64_t sequence_number = 13371337;
const base::TimeTicks event_time = base::TimeTicks::Now();
const uint32_t event_count = 1234;
LatencyInfo::LatencyComponent input;
- input.sequence_number = sequence_number;
input.event_time = event_time;
input.event_count = event_count;
mojom::TraitsTestServicePtr proxy = GetTraitsTestProxy();
LatencyInfo::LatencyComponent output;
proxy->EchoLatencyComponent(input, &output);
- EXPECT_EQ(sequence_number, output.sequence_number);
EXPECT_EQ(event_time, output.event_time);
EXPECT_EQ(event_count, output.event_count);
}
@@ -82,10 +79,10 @@ TEST_F(StructTraitsTest, LatencyInfo) {
LatencyInfo latency;
latency.set_trace_id(5);
ASSERT_FALSE(latency.terminated());
- latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234, 0);
- latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234, 100);
+ latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234);
+ latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234);
latency.AddLatencyNumber(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT,
- 1234, 0);
+ 1234);
EXPECT_EQ(5, latency.trace_id());
EXPECT_TRUE(latency.terminated());
@@ -106,7 +103,6 @@ TEST_F(StructTraitsTest, LatencyInfo) {
LatencyInfo::LatencyComponent rwh_comp;
EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234,
&rwh_comp));
- EXPECT_EQ(100, rwh_comp.sequence_number);
EXPECT_EQ(1u, rwh_comp.event_count);
EXPECT_TRUE(output.FindLatency(

Powered by Google App Engine
This is Rietveld 408576698